feat(e2e): add 10s timeout for test steps#103
Merged
branchseer merged 2 commits intomainfrom Jan 14, 2026
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
branchseer
force-pushed
the
01-14-e2e_timeout_support
branch
from
292e8ee to
bf60d66
Compare
Add timeout support for e2e snapshot tests to prevent hanging tests: - Convert test harness to async using tokio runtime - Each step has a 10-second timeout - When timeout occurs: - Kill the child process - Mark step with [timeout] instead of exit code - Capture partial stdout/stderr before timeout - Skip remaining steps in the test case - Uses concurrent I/O to read stdout/stderr while waiting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace separate `timed_out` and `exit_status` variables with a unified `TerminationState` enum that better represents the three possible states: - Running (implicitly `None`) - Exited with status - Timed out Benefits: - Eliminates impossible state combinations - More idiomatic Rust with pattern matching - Clearer intent and better type safety - Loop now returns the termination state directly Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
branchseer
force-pushed
the
01-14-e2e_timeout_support
branch
from
bf60d66 to
c5690c9
Compare
fengmk2
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timeout support for e2e snapshot tests to prevent hanging tests:
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com