Skip to content

feat: improve cache miss messages with specific input change kinds#209

Merged
branchseer merged 3 commits intomainfrom
03-09-feat_improve_input_change_messages
Mar 9, 2026
Merged

feat: improve cache miss messages with specific input change kinds#209
branchseer merged 3 commits intomainfrom
03-09-feat_improve_input_change_messages

Conversation

@branchseer
Copy link
Member

@branchseer branchseer commented Mar 8, 2026

Summary

Cache miss messages now tell you what changed instead of a generic "content of input changed":

  • Modified: cache miss: 'src/main.ts' modified
  • Added: cache miss: 'new-file.ts' added in src
  • Removed: cache miss: 'old-file.ts' removed from src

Before:

✗ cache miss: content of input 'src/main.ts' changed, executing

After:

✗ cache miss: 'src/main.ts' modified, executing
✗ cache miss: 'new-file.ts' added in 'src', executing
✗ cache miss: 'old-file.ts' removed from 'src', executing

Works for both explicit glob inputs and inferred (fspy-tracked) inputs. Files at the workspace root show "added in workspace root" / "removed from workspace root".

Test plan

  • E2E tests for all three change kinds (modified/added/removed) for both glob and inferred inputs
  • All existing e2e snapshot tests updated and passing
  • cargo test, just lint

🤖 Generated with Claude Code

Copy link
Member Author

branchseer commented Mar 8, 2026

@branchseer branchseer marked this pull request as ready for review March 8, 2026 21:48
@branchseer branchseer requested a review from fengmk2 March 8, 2026 21:49
@branchseer branchseer force-pushed the 03-09-feat_improve_input_change_messages branch from 3cbadfa to e9dc057 Compare March 8, 2026 22:15
Copy link
Member Author

branchseer commented Mar 9, 2026

Merge activity

  • Mar 9, 1:15 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 9, 1:16 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 9, 1:17 AM UTC: @branchseer merged this pull request with Graphite.

@branchseer branchseer changed the base branch from 01-14-feat_explicit_inputs to graphite-base/209 March 9, 2026 01:15
@branchseer branchseer changed the base branch from graphite-base/209 to main March 9, 2026 01:15
branchseer and others added 3 commits March 9, 2026 01:16
Unify GlobbedInput and PostRunFingerprint mismatch variants into a
single InputChanged { kind, path } with Added/Removed/ContentModified
discrimination. Messages now show '{path} modified', '{file} added in
{dir}', or '{file} removed from {dir}' instead of generic 'content of
input changed'.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# Conflicts:
#	crates/vite_task_bin/tests/e2e_snapshots/fixtures/inputs-negative-glob-subpackage/snapshots/dotdot auto negative - miss on non-excluded sibling inferred file.snap
Enables sorted lockstep diffing consistent with
detect_globbed_input_change.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
'file' added in 'src' instead of 'file' added in src.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@branchseer branchseer force-pushed the 03-09-feat_improve_input_change_messages branch from e9dc057 to a24bb7b Compare March 9, 2026 01:16
@branchseer branchseer merged commit cc70fae into main Mar 9, 2026
6 checks passed
@branchseer branchseer deleted the 03-09-feat_improve_input_change_messages branch March 9, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants