Repository navigation
Conversation
Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
|
Independent review of Two concrete blockers:
Optional improvements:
The write-ahead delivery/fingerprint ordering is sound for the stated single-publisher deployment. Strong reads, signature validation, bounded bodies/plans/responses, expired-plan refresh after confirmed absence, and the dedicated publisher identity match the design. Evidence: source review of normalization, request verification/admission, relay acknowledgements, and journal planning; comparison with the production NIP-10 parser and official Linear payload documentation. Existing HTTP journeys and clippy pass, but their fake relay did not classify threads. Live local relay acceptance is being exercised separately. No provider or production changes were made. Minimalism: 9/10. Elegance: 8/10 until routing precedence has one consistent owner. Correctness: 7/10 until both blockers are fixed. Optional items do not gate readiness. |
Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Independent follow-up review of I also exercised the published service against a real local relay in an isolated database/community. A verified GitHub fixture created the durable plans, one anchor, one direct occurrence reply, and one trusted workflow response. Stored thread metadata has depths 0/1/2; the anchor has The bounded admission queue retains the four-second end-to-end deadline. Current explicit Linear mappings take precedence over saved issue routing, with a production-router regression. No remaining concrete blocker in this follow-up. Minimalism 9/10, elegance 9/10, correctness 9/10. This was local agent validation. Human runtime confirmation and deployment validation remain outstanding; the PR stays draft. |
Problem and behavior
GitHub reviews/CI, Linear issues, and public Slack discussions need a searchable Buzz record.
buzz-ingestverifies provider webhooks and publishes ordinary channel threads, while Buzz workflows consume trusted integration messages. Provider-specific HTTP handlers remain outside the relay.integration_eventselects source/action and requires explicit trusted publisher keys. Metadata is available astrigger_*values.flowchart LR P[Provider] -->|HMAC-verified webhook| I[buzz-ingest] I -->|strong reads and signed write-ahead plans| R[Buzz relay] I -->|kind 9 anchor and occurrence reply| R R --> W[Trusted integration workflow] R --> C[Buzz and Paseo conversation history]Kind 30623 stores bounded, base64-encoded signed plans before messages. Provider delivery and canonical payload fingerprint coordinates recover the same event after partial failure, restart, or changed unsigned headers. Every lookup requests writer consistency. An expired pending event changes only after an authoritative empty ID lookup; read errors propagate.
The service requires one replica with Recreate. It bounds bodies, labels, request rates, relay responses, and delivery deadlines. All external callbacks use the existing HTTPS hostname; the chart adds no NAT or database. The image uses a read-only nonroot runtime and joins the existing native ECR build matrix.
Validation
-D warnings, and tests pass. Existing core integration tests and workflow tests also pass.actionlintpass.just cipasses workspace Rust formatting/clippy, then stops at native Tauri clippy: this machine cannot locateglib-2.0.pc. Later repository lanes are unverified.The container compile/runtime contract test and real provider/relay delivery remain deployment validation. No production resources or provider settings were changed.
Rollout and review
Companion deployment: https://github.com/voltagecloud/cd/pull/677
buzz-ingestand grant the existing image publisher access.The chart refuses its placeholder digest until an actual image is supplied. Full configuration and replay procedures are in
crates/buzz-ingest/README.mdanddocs/nips/NIP-IG.md.Independent review found missing reply markers and stale saved-route precedence. Both are fixed; regressions bind the production NIP-10 parser and current mapping through the HTTP router. A bounded 32-request admission queue also handles ordinary concurrent CI deliveries under the existing four-second deadline.
This PR remains draft pending human workflow confirmation. No
review completion markerattestation is present.