feat: new option: restrict path aliases that do not start with the prefix (close #1646) by LincZero · Pull Request #1647 · vuepress/core

LincZero · 2025-04-29T16:47:49Z

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

Bug fix
New feature
Documentation update
Other

Description

close #1646

Screenshots

Before

After

Mister-Hope

Since Vite's default static file is covering media files, we can also handle video and audio here as well.

coveralls · 2025-04-29T18:32:28Z

Pull Request Test Coverage Report for Build 21834429282

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 74.155%

Totals
Change from base Build 21831331239:	0.1%
Covered Lines:	700
Relevant Lines:	945

💛 - Coveralls

Mister-Hope

Like I said previously, video and audio tags shall also be tracked.

This means you should also modify the regexp in the first replacer function.

LincZero · 2025-04-29T21:24:39Z

Should the unit test of the media tag be conducted in assetsPlugin.spec.ts.

This won't be available for supplementation until tomorrow.

Mister-Hope · 2025-04-30T02:18:39Z

Audio and video tags can have src attribute.

Mister-Hope · 2025-08-06T07:10:09Z

@meteorlxy Needs review here.

Mister-Hope · 2026-03-10T00:23:30Z

Updated: we have finished our work on #1606, and we might still need this in some cases.

We will try to merge this soon after merging #1606

Mister-Hope · 2026-03-20T00:51:25Z

Can you try to rework this under the new bundler resolution?

The logic would be more simple than before.

Mister-Hope · 2026-03-20T10:29:28Z

You should update e2e test at markdown/image

Copilot

Pull request overview

This PR introduces a new aliasSupport option to the markdown assetsPlugin to control how “non-strict” asset paths (those not starting with ./, ../, /, or a protocol) are treated—either as aliases (current behavior) or as relative paths (by prepending ./). It also expands the HTML asset rewriting to include additional media tags beyond <img>.

Changes:

Add aliasSupport?: boolean | '@-prefix' to assetsPlugin and thread it into link resolution logic.
Extend HTML asset attribute rewriting from <img> to <audio>, <video>, and <source>.
Add test coverage for HTML media tags using the new option.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
packages/markdown/src/plugins/assetsPlugin/assetsPlugin.ts	Adds `aliasSupport` option + expands HTML tag matching to more media tags.
packages/markdown/src/plugins/assetsPlugin/resolveLink.ts	Implements the `aliasSupport` behavior in link resolution.
packages/markdown/tests/plugins/assetsPlugin.spec.ts	Adds tests for media tags and the new option behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

feat: restrictRelativePath option

7e8e5ed

LincZero mentioned this pull request Apr 29, 2025

[Feature request] Add img_alias_limit #1646

Open

Mister-Hope requested changes Apr 29, 2025

View reviewed changes

Comment thread packages/markdown/src/plugins/assetsPlugin/assetsPlugin.ts Outdated

Comment thread packages/markdown/src/plugins/assetsPlugin/assetsPlugin.ts Outdated

feat: restrictRelativePath option 2

2b5e08d

LincZero requested a review from Mister-Hope April 29, 2025 18:47

LincZero changed the title ~~feat: restrictRelativePath option~~ feat: restrictRelativePath option (close #1646) Apr 29, 2025

Mister-Hope requested changes Apr 29, 2025

View reviewed changes

LincZero added 3 commits April 30, 2025 04:46

chore: update comment

300cfdc

feat(markdown): assetsPlugin support media tags

77481bb

feat(markdown): change option name 'aliasSupport'

5371236

LincZero requested a review from Mister-Hope April 29, 2025 21:24

Mister-Hope reviewed Apr 30, 2025

View reviewed changes

Comment thread packages/markdown/src/plugins/assetsPlugin/assetsPlugin.ts Outdated

LincZero added 2 commits April 30, 2025 17:17

feat(markdown): change option name 'aliasSupport'2

ba53e97

chore(markdown): add media tags unit test

a7a557c

LincZero requested a review from Mister-Hope April 30, 2025 09:46

Mister-Hope previously approved these changes Apr 30, 2025

View reviewed changes

Mister-Hope requested a review from meteorlxy April 30, 2025 09:50

Merge branch 'main' into main

8620512

Mister-Hope added 2 commits February 10, 2026 01:27

Merge branch 'main' into main

91a8d25

Merge branch 'main' into main

ac344c2

Merge branch 'main' into main

3cc48ba

LincZero dismissed Mister-Hope’s stale review via 3cc48ba March 20, 2026 07:55

LincZero marked this pull request as draft March 20, 2026 08:04

LincZero changed the title ~~feat: restrictRelativePath option (close #1646)~~ feat: new option: restrict path aliases that do not start with the prefix (close #1646) Mar 20, 2026

Mister-Hope reviewed Mar 20, 2026

View reviewed changes

Comment thread packages/markdown/src/plugins/assetsPlugin/assetsPlugin.ts Outdated

LincZero added 2 commits March 20, 2026 17:56

chore(markdown): reimplement aliasSupport

d101b51

chore(markdown): optimize reg

34e7e1f

LincZero requested a review from Mister-Hope March 20, 2026 10:06

Mister-Hope previously approved these changes Mar 20, 2026

View reviewed changes

Mister-Hope marked this pull request as ready for review March 20, 2026 10:29

Copilot AI review requested due to automatic review settings March 20, 2026 10:29

Copilot started reviewing on behalf of Mister-Hope March 20, 2026 10:29 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

chore(markdown): optimize code

688ce71

LincZero dismissed Mister-Hope’s stale review via 688ce71 March 20, 2026 10:43

chore(markdown): optimize aliasSupport code

d2e1f58

Mister-Hope requested a review from Copilot March 21, 2026 06:46

Copilot started reviewing on behalf of Mister-Hope March 21, 2026 06:47 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

chore(markdown): optimize aliasSupport code

7574a1f

Conversation

LincZero commented Apr 29, 2025

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

Screenshots

Uh oh!

Mister-Hope left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coveralls commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21834429282

Details

💛 - Coveralls

Uh oh!

Mister-Hope left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LincZero commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mister-Hope commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Mister-Hope commented Aug 6, 2025

Uh oh!

Mister-Hope commented Mar 10, 2026

Uh oh!

Mister-Hope commented Mar 20, 2026

Uh oh!

Uh oh!

Mister-Hope commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Apr 29, 2025 •

edited

Loading

LincZero commented Apr 29, 2025 •

edited

Loading

Mister-Hope commented Apr 30, 2025 •

edited

Loading