Repository navigation
fix: late replies, unknown backgrounds, small windows, and --cells - #151
Merged
Merged
Conversation
A slow terminal's answers to the start-up probe arrived after its 250 ms deadline and crossterm read the background colour as Alt+] (next year), r (reload) and two d's (cell style). The probe now waits 500 ms and gives a terminal that has started answering a second window to finish; anything later is swallowed in the key handler up to its terminator, and Alt keys no longer act as their plain letter. Fixes #140 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
With no OSC 11 answer the appearance fell back to dark, and on a light terminal the chrome was #f0f6fc at about 1.07:1. Text now uses the terminal's default colour and only the cells keep GitHub's; the help overlay offers --theme light; sixel edges are cut instead of blended into a guessed dark canvas. README: native Windows never probes, so it needs --graphics sixel --cell WxH. Fixes #141 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
The source label trimmed q quit off the footer before itself, and a short window lost the note and the footer under the statistics. Short windows now give up the summary, spacing, detail and legend first; below the smallest chart they say "terminal too small (needs W×H) — q quits". The failure screen offers u only where it works, and the tooltip marker no longer overwrites a month label. Fixes #139 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
--cells STYLE starts the chart in a named cell style, and mossaic-glyphs points at it. Pixel cells forced into a window too narrow for them drew nothing; they now draw the weeks that fit, and d from a style that does not fit goes to the best one that does. A terminal that speaks kitty or sixel without reporting its cell size is told to pass --cell WxH. Fixes #142 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
Both always sent truecolour on the dark theme. They now use the chart's palette: the 256-colour ramp unless COLORTERM says otherwise, and the theme of the background the terminal reports, which --draw and an interactive mossaic-glyphs now ask for. The late-reply filter moves to term::LateReplies so the editor can drop a reply instead of painting it. Fixes #143 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
Resolves the conflicts with #149 and #150: the failure screen wraps (#133) in the terminal's own colours and offers u only where it works (#139); the season follows --today (#136) and the chrome follows a known background (#141); both branches' new tests kept; one Added/Changed/Fixed list under Unreleased, every bullet kept. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
an_unknown_background_leaves_the_text_to_the_terminal expected truecolour, which it got only where COLORTERM says so. CI's runners set none, so the palette fell back to the 256-colour ramp and the test failed on every OS and in every stress shard. It now expects each Primer value converted the way the app converts it here, and a cell colour of either kind. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal compatibility: slow terminals, light terminals, small windows, and choosing a cell style.
ESC ]/ESC _/ESC Preply is swallowed up to its ST or BEL, capped at 128 keys or 250 ms so a person's real Alt+]can't lock the keyboard. Alt keys are ignored in normal mode. A PTY test sends a dark kitty's replies after the first frame, and the chart doesn't change.Color::Reset), so it reads on a light terminal. Sixel edges are cut rather than blended into an assumed dark canvas. The help overlay suggests--theme light. README no longer claims native Windows draws pixels by itself; it needs--graphics sixel --cell WxH.q quit, and lines are given up in a fixed order with the note and footer kept to last. Below the minimum height it shows "terminal too small (needs W×H) — q quits". The failure and empty-year screens offer only keys that work, and the tooltip marker no longer overwrites month labels.--cellsoption, and forced pixels in a narrow window draw nothing #142: a new--cells STYLEoption. Forced pixel cells in a narrow window draw the weeks that fit instead of nothing.dfrom a style that doesn't fit goes to the first that does. The--cell WxHhint appears whenever kitty or sixel is spoken but no cell size is known. mossaic-glyphs points at--cells.COLORTERM(the 256-colour fallback) and a known background, as the chart does. The editor filters late replies too.main (#148–#150) is merged in. The conflicts were in
app.rs,ui.rs, both test files, README and CHANGELOG. The failure screen now wraps (#133) in the terminal's own colours and offersuonly where it works (#139), and the season follows--today(#136). Checks on the merged tree: fmt and clippy-D warningsclean,cargo test --all-features299 passed,--test cli -- --ignored4 passed, rustdoc-D warnings. The event loop changed, so the stress workflow is dispatched on this branch.Closes #139
Closes #140
Closes #141
Closes #142
Closes #143
Signed-off-by: Vyncint Ng 115854244+vyncint@users.noreply.github.com