Repository navigation
test(search): time a search beside its reference, three tries - #739
Merged
Merged
Conversation
every_search_costs_a_small_multiple_of_the_work_it_cannot_avoid timed the reference once and each search from two runs, so a scheduler that parked the search on a loaded runner failed it: a Windows stress shard at 16 threads (run 42836205989, iteration 18 of 25) saw find_all at 9.1 ms against an 0.89 ms reference, 10.2 times where the bound is 10. Each search is now timed beside its reference, the fastest of three runs of each, and the pair is timed again, up to three times, before the bound is called broken. The regression the test exists for (#584) was hundreds of times, every time, and it still fails: with find_all made 20 times slower the test fails at 23 times, three times over. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search-cost test flaked on a Windows stress shard at 16 threads (run 42836205989, iteration 18 of 25):
find_alltook 9.1 ms against a 0.89 ms reference, 10.2 times where the bound is 10. It timed the reference once and each search from two runs, so a scheduler that parked the search failed it.Each search is now timed beside its reference (the fastest of three runs of each), and the pair is timed again, up to three times, before the bound is called broken. The regression the test exists for (#584) was hundreds of times, every time. A mutation check,
find_allmade 20 times slower, still fails it: 23 times, three times over.Test-only, so no CHANGELOG entry.