Hook DiffStateModel to remote server#10470
Open
MaggieShan wants to merge 1 commit intomaggs/diffstatemodel-protosfrom
Open
Hook DiffStateModel to remote server#10470MaggieShan wants to merge 1 commit intomaggs/diffstatemodel-protosfrom
DiffStateModel to remote server#10470MaggieShan wants to merge 1 commit intomaggs/diffstatemodel-protosfrom
Conversation
MaggieShan
changed the title
DiffStateModel to remote server
MaggieShan
force-pushed
the
maggs/hook-diffstatemodel-to-server
branch
from
6d72bb7 to
56a3a62
Compare
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds server-side diff-state models, proto conversions, subscriptions, and remote-client event forwarding for diff-state snapshots and deltas.
Concerns
- New
GetDiffStaterequests can be left pending forever when repo detection does not produce aLocalDiffStateModelevent. - Immediate snapshots for already-loaded models drop
content_at_head, so later subscribers do not receive the same renderable diff data as the initial async load.
Security
DiscardFilesforwards client-supplied file paths into destructive git restore/clean/stash behavior without validating that every path is repo-relative and contained by the requested repo.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
MaggieShan
force-pushed
the
maggs/hook-diffstatemodel-to-server
branch
2 times, most recently
from
d837ed7 to
04a8618
Compare
MaggieShan
force-pushed
the
maggs/diffstatemodel-protos
branch
from
d72a06a to
faad40b
Compare
MaggieShan
force-pushed
the
maggs/hook-diffstatemodel-to-server
branch
2 times, most recently
from
9a75372 to
1f57582
Compare
MaggieShan
force-pushed
the
maggs/hook-diffstatemodel-to-server
branch
from
1f57582 to
7e9e78e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DiffStateModel#10428DiffStateModeland git states on remote environmentsGlobalDiffStateModelto track eachLocalDiffStateModelperrepo_path,diff_modeLinked Issue
APP-4355
Testing
No-op
Agent Mode