PCRE2 migration on top of April 2026 updates#79
Open
cmhac wants to merge 8 commits intowashingtonpost:developfrom
Open
PCRE2 migration on top of April 2026 updates#79cmhac wants to merge 8 commits intowashingtonpost:developfrom
cmhac wants to merge 8 commits intowashingtonpost:developfrom
Conversation
- Update pre-commit hook versions to current stable releases - isort: 5.10.1 → 5.13.2 - black: 21.9b0 → 24.10.0 - pre-commit-hooks: v4.0.1 → v5.0.0 - flake8: v2.3.0 → 7.1.1 - Fix linting issues: - Remove unused imports (pytest, time) - Add missing final newlines - Auto-format code with black and isort
- Update function signatures to use std.Build.Step.Compile - Update addCSourceFiles API to use new struct syntax - Update target checking API for Darwin detection - Remove deprecated CrossTarget import
- Add complete PCRE2 10.42 source tree in src/pcre2/ - Includes all headers, source files, and build configuration - No functional changes, pure vendor import
- Delete src/pcre/ directory and all PCRE v1 files - No functional impact, just cleanup before PCRE2 migration
- Add thin regex wrapper and switch headers/types/flags - Support vendored PCRE2 with toggle; default to vendored - Produce wasm to zig-out/lib and adjust CI Windows artifact path - Restore missing Python/CI files and benchmarking script Notes: - Preserves behavior; all C tests (21/21) and Python tests (8/8) pass - CI release and wheels workflows tested across platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the PCRE2 migration work onto our April 2026 branch line.
Includes
Important dependency
This branch was created from the april-2026-updates line and currently includes those commits.
Please merge #78 first; this PR is intended to stack on top of it.
Validation