Repository navigation
chore(⬆️): move the example and the docs app to react-native-skia 3.9.0 - #605
Merged
Merged
Conversation
react-native-skia 3.9.0 depends on react-native-webgpu-dawn 157.1.0, the version this package pins since #580, so the workspace no longer needs to resolve the package for both: the example resolves one Dawn on its own. The compatibility table gets the 0.20.0 / 3.9.0 row. Verified on the iPhone 17 simulator: pod install reports one Dawn (157.1.0) without the resolution, check-dawn and the Swift manifest pass, the example builds and the full e2e suite passes (45 suites, 231 tests).
react-native-skia 3.9 reads pixels asynchronously: readPixels() returns a promise, which settles on the runtime that asked, the UI runtime here. The inference is scheduled from its callback, as it was from the value.
|
🎉 This PR is included in version 0.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native-skia 3.9.0 depends on
react-native-webgpu-dawn157.1.0, the version this package pins since #580, so the workspace resolution added there goes: the example resolves one Dawn on its own (pod installreports "Dawn versions match (157.1.0)" without it, and the Swift manifest's resolved-version check passes). The docs app moves with it, as in #585, so the SwiftPM example keeps resolving one react-native-skia in the workspace. The compatibility table on the react-native-skia integration page gets the 0.20.0 / 3.9.0 row, with 0.17.0 to 0.19.2 paired with 3.7.0 to 3.8.1.One API change on the way:
readPixels()returns a promise since react-native-skia 3.9, so the MNIST demo schedules its inference from the readback's callback (the promise settles on the UI runtime, where the gesture draws). Type-checked and linted; the demo itself was not exercised by hand.Verified on the iPhone 17 simulator:
yarn check-dawnpasses, the example builds, and the full e2e suite passes (45 suites, 231 tests).Counterpart in react-native-skia: wcandillon/react-native-skia#4383 moves its example to react-native-webgpu 0.20.0 and drops its own resolution.