Repository navigation
fix(🍏): declare tvOS in the podspec so autolinking links the pod on Apple TV - #609
Merged
Merged
Conversation
…pple TV (#608) React Native's CocoaPods autolinking skips any pod whose podspec does not list the Podfile target's platform, so on a tvOS target react-native-webgpu was silently left out of the installed pods. The Dawn xcframework already ships tvOS device and simulator slices and the sources build on tvOS since #607; only the platforms declaration was missing. The tvOS floor matches the iOS one, as in react-native-tvos' own min_supported_versions.
…lice Since #507 Dawn comes from react-native-webgpu-dawn, whose xcframework has no xros or xrsimulator slice, so a visionOS target autolinked the pod and then failed to link it. Drop the claim from the podspec and the docs until the Dawn package ships visionOS binaries again.
|
🎉 This PR is included in version 0.21.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #608.
Problem
React Native's CocoaPods autolinking only links a pod when its podspec declares the Podfile target's platform (
AutolinkingUtils.is_platform_supported?callsspec.supported_on_platform?(platform.name)). The podspec listed iOS, macOS and visionOS only, so on a tvOS targetreact-native-webgpuwas silently dropped from the autolinking list:pod install, archive and export all succeed, and the app then fails at runtime because the native module is absent.Everything else was already in place: the Dawn xcframework ships
tvos-arm64andtvos-arm64_x86_64-simulatorslices, and #607 made the Apple sources compile on tvOS.Change
react-native-webgpu.podspec: add:tvostos.platforms. The floor ismin_ios_version_supported(15.1), which is what react-native-tvos uses for tvOS in its ownmin_supported_versionshelper and whatcheck-apple-sdks.shalready targets.react-native-webgpu.podspec: drop:visionos. Since feat(🌅): link Dawn from the react-native-webgpu-dawn package #507 Dawn comes from thereact-native-webgpu-dawnpackage, whose xcframework has noxrosorxrsimulatorslice (the in-repo build it replaced did produce them). A visionOS target therefore autolinked the pod and then failed to link it. The claim comes back once the Dawn package ships visionOS binaries again.Verification
Evaluated the podspec with CocoaPods 1.16.2 and React Native 0.83's
AutolinkingUtils.is_platform_supported?against a fake target per platform:scripts/check-apple-sdks.shpasses for every SDK, including appletvos and appletvsimulator. The reporter confirmed that patching the podspec this way makes their Expo Apple TV app work.