Repository navigation
chore(🧹): remove what the in-repo Dawn build left behind - #610
Merged
Merged
Conversation
Dawn comes from react-native-webgpu-dawn since #507 and the codegen went in #424. Drop the gitignore rules, cpplint excludes and devDependencies that only served them, and make check-dawn fail on header copies left over from the old build: they sit before the package's include directory on every include path and silently shadow the headers the binaries were built from.
|
🎉 This PR is included in version 0.21.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dawn has been built by react-native-skia and consumed through the
react-native-webgpu-dawnpackage since #507, and the C++ codegen went in #424. This removes what those changes left behind, and adds a guard for the one leftover that can bite.Removed
.gitignore:!packages/webgpu/scripts/build(twice) negated a directory deleted in feat(🌅): link Dawn from the react-native-webgpu-dawn package #507;artifacts/was the prebuilt-binaries download folder from Add a way to download prebuilt binaries #111;package/liband.package/.yarn/*predate the workspace layout;packages/webgpu/libsandpackages/webgpu/libduplicated the package-level rules. Thecpp/webgpu/andcpp/dawn/*rules hid the header copies the old build left behind (see below).example,iosandcpp/webgpuexcludes no longer match anything. Addedlibs, which holds the Dawn xcframework copied in atpod install, soyarn cpplintruns clean on a machine that has runpod install(it reported 726 errors from those vendored headers; CI never had the folder).yargs(prebuilt-binaries downloader, Add a way to download prebuilt binaries #111),del-cliandrimraf(Migrate to yarn workspace #91) andbaseline-browser-mapping(fix(🏎️): switch to native state #298) have no references anywhere in the package. browserslist still resolvesbaseline-browser-mappingtransitively.Guard against stale header copies
Until #507 the build copied Dawn's headers into
cpp/webgpuandcpp/dawn. Every source includes"webgpu/webgpu_cpp.h", and both the podspecHEADER_SEARCH_PATHSandandroid/CMakeLists.txtlistcppbefore the package's include directory, so a copy left over from that build silently wins over the headers the binaries were built from. A checkout that had run the old build still had such a copy, differing from the 157.1.0 headers by thousands of lines, hidden by the ignore rules.scripts/check-dawn.ts(run by the setup action afteryarn install) now fails whencpp/webgpuor anything other thancpp/dawn/commonexists, naming the directories to delete. Dropping the ignore rules makes such copies show up as untracked files as well.Kept on purpose
check-dawn.tsandcheck-apple-sdks.share live.cpp/dawn/common/ExternalTextureParams.his vendored by design and tracked by the Dawn check. Thedawnfield in package.json is read byPackage.swiftfor the Skia 3.0.x Graphite compatibility check.