Repository navigation
Fix build error on iOS with use_frameworks - #612
Merged
wcandillon merged 1 commit intoNov 6, 2026
Merged
Conversation
Sources include headers from other folders by bare name ("GPU.h").
use_frameworks! drops Pods/Headers/Private and the header map is
off (wcandillon#438), so those includes failed with "file not found". Put
every folder of internalHeaderDirs on HEADER_SEARCH_PATHS, the
same list the Swift package uses.
wcandillon
self-requested a review
November 6, 2026 16:38
wcandillon
approved these changes
Nov 6, 2026
Owner
|
Thank You 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps that use
use_frameworks!do not compile. Some apps need it, for example apps with Firebase.Cause: the sources include headers from other folders by file name only (
#include "GPU.h"). Without frameworks, CocoaPods copies all headers into one flat folder (Pods/Headers/Private), and these includes resolve there. With frameworks, CocoaPods does not make that folder. Xcode's header map could also find them, but #438 turned it off to stop Skia headers from leaking in.Fix: add each source folder that holds headers to
HEADER_SEARCH_PATHS. It is the same list asinternalHeaderDirsinPackage.swift