Repository navigation
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
jfrancoa
force-pushed
the
jose/decisions-openai
branch
from
October 12, 2026 21:55
ca45aff to
941bd58
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jose/decisions-typesafeai #2189 +/- ##
=============================================================
- Coverage 88.95% 88.81% -0.14%
=============================================================
Files 310 310
Lines 24692 24695 +3
=============================================================
- Hits 21965 21934 -31
- Misses 2727 2761 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jfrancoa
force-pushed
the
jose/decisions-openai
branch
from
October 13, 2026 13:21
941bd58 to
933bcc4
Compare
…nai module `Configure.Decisions.openai(model, base_url, max_documents, question)` builds a `decisions_config` for the `decisions-openai` module, which is backed by OpenAI's Decisions API. `DecisionsQuestion` picks what the module asks about every object of a `rerank`: the relevance of the object to the query, or the query as a statement about the object. The integration test needs an OpenAI key and the module on the server, and skips otherwise.
Both decisions modules take the same class defaults for a rerank: the threshold that drops a result and whether the search order is kept.
jfrancoa
force-pushed
the
jose/decisions-openai
branch
from
October 13, 2026 13:24
933bcc4 to
7cc18b0
Compare
jfrancoa
force-pushed
the
jose/decisions-typesafeai
branch
from
October 13, 2026 13:24
e106f58 to
2275aaf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Configure.Decisions.openai(...)andReconfigure.Decisions.openai(...)for thedecisions-openaimodule (server: weaviate/weaviate#13409, weaviate/weaviate#13485), with thequestionsetting (relevance or statement for a plainrerank),min_probabilityandorderas rerank defaults,model,base_urlandmax_documents.decide=works as withdecisions-typesafeai(#2188).Tests
Unit: serialisation, update within the decisions kind, read-back. Integration (
integration/test_collection_decisions_openai.py): against the API; needsOPENAI_APIKEYand the module on the server, skips otherwise.Stacked on #2188.