Repository navigation
test(menu): drive dev:mode through the prompt - #37
Merged
Merged
Conversation
dev:mode was tested directly and the menu machinery was tested, but the two were never exercised together, so the path a user actually takes was only ever verified by hand. The prompt is built from the command's own definition, so a wrapped command belongs in the menu's tests too. The test selects dev:mode, toggles --disable with Space, submits, and asserts the real side effects: the active file and the config cache are both gone, and the result frame reports success. Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A test for the path a user actually takes: the menu selecting
dev:mode, toggling--disablewithSpace, submitting, and the command running for real.
That combination had no coverage.
dev:modewas tested directly and the menu machinery was testedagainst fixtures, but nothing exercised the two together — so the prompt being built from a real
command's definition, and the flags it produces reaching the command, was only ever verified by hand.
The prompt is generated from the command's own
InputDefinition, so a wrapped command belongs in themenu's tests as well as in its own.
It asserts the real side effects, not just rendered text: the active file and the config cache are
both gone afterwards, and the result frame reports success.
Gates
mago fmt --check/lint/analyze/guardRefs #35