Repository navigation
fix(dev:mode): name the path each file action touches - #41
Merged
Merged
Conversation
The enable and disable descriptions now say which files they create and remove (config/development.config.php from its .dist, and the active and local files), so "create" can only mean the config file and never the config cache. The command docblock states the same rule, and the usage-text assertion in the test follows. Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist:
1.0.x)Description
The
dev:modeaction descriptions said "Create the active file" and "Remove the active file", which does not say which file, and "create" could be read as creating the config cache. They now name the paths:enablecreatesconfig/development.config.phpfromconfig/development.config.php.dist, anddisableremovesconfig/development.config.phpandconfig/autoload/development.local.php. The docblock states the rule and the unit test follows.How has this been tested?
mago format --check,lint,analyze,guardexit 0.composer test: 145 tests.composer test-integration: 2 tests.composer mutation-test: 397 mutants, covered MSI 100%.