Skip to content

fix(dev:mode): name the path each file action touches - #41

Merged
tyrsson merged 1 commit into
1.0.xfrom
fix/dev-mode-action-descriptions
Oct 1, 2026
Merged

tyrsson merged 1 commit into
1.0.xfrom
fix/dev-mode-action-descriptions

Conversation

@tyrsson

@tyrsson tyrsson commented Oct 1, 2026

Copy link
Copy Markdown
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests for my changes. (The usage-text assertion is updated.)
  • All new and existing tests passed.
  • This pull request targets the correct branch. (1.0.x)

Description

The dev:mode action descriptions said "Create the active file" and "Remove the active file", which does not say which file, and "create" could be read as creating the config cache. They now name the paths: enable creates config/development.config.php from config/development.config.php.dist, and disable removes config/development.config.php and config/autoload/development.local.php. The docblock states the rule and the unit test follows.

How has this been tested?

mago format --check, lint, analyze, guard exit 0. composer test: 145 tests. composer test-integration: 2 tests. composer mutation-test: 397 mutants, covered MSI 100%.

The enable and disable descriptions now say which files they create and remove (config/development.config.php from its .dist, and the active and local files), so "create" can only mean the config file and never the config cache. The command docblock states the same rule, and the usage-text assertion in the test follows.

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tyrsson tyrsson added the enhancement New feature or request label Oct 1, 2026
@tyrsson
tyrsson merged commit 32d7340 into 1.0.x Oct 1, 2026
12 checks passed
@tyrsson
tyrsson deleted the fix/dev-mode-action-descriptions branch October 1, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant