Repository navigation
fix(console): scope the bin entry point and type the container correctly - #64
Merged
Merged
Conversation
Wrap the entry point body in a self-called closure so requiring the config files no longer leaks their internals into the global namespace, narrow the container to a ContainerInterface and ServiceManager intersection, and replace the two mojibake dashes with plain punctuation so the file is ASCII-only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bin/webwareno longer runs at file top level. The entry point body is wrapped in a self-called closure, so requiringconfig/container.phpcan no longer leak$config,$dependencies, and the other locals into the global namespace.The container annotation is corrected from
@var ContainerInterfaceto@var ContainerInterface&ServiceManager.config/container.phpreturns aLaminas\ServiceManager\ServiceManager, and the old annotation described a PSR-11 container the file never produced.Two mojibake dashes in the comments were replaced with plain punctuation, so the file is ASCII-only.
Why
This is the same defect found in
phpiidoc/bin/phpiidocat line 54: the annotation described something the call does not return, and the config files executed in global scope.Scope
One file. No behaviour change to command resolution or dispatch.