Repository navigation
Conversation
rc.13 adds the fleet-wide mago guard structural naming rules and exempts PHPUnit test roots from those rules, so the guard gate passes with no baseline and no suppression. Earlier releases were unusable here because the structural rules matched test classes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
Superseded by #66, which bumps to ^1.0.0-rc.14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
webware/webware-toolsdev dependency from^1.0.0-rc.8to^1.0.0-rc.13.rc.13 adds the fleet-wide mago guard structural naming rules and, in the same release, exempts
PHPUnit test roots from those structural rules. Earlier releases were unusable in this repo because
the structural rules matched test classes.
Lock resolution
webware/webware-tools:1.0.0-rc.8->1.0.0-rc.13616fab6567178099f738da897e72e18761976397The lock diff is
webware/webware-toolsplus thecontent-hashonly. No other package moved.Gates
Run locally on Windows, PHP 8.5.12,
core.autocrlffalse:mago guardreports zero issues with no baseline added, no[[issues]]entry, no suppression, andno narrowing in
mago.toml.The 8 unit failures are pre-existing and Windows-only
All 8 are in
DevelopmentModeCommandTestand fail becausesymlink()is not permitted for thisWindows account (no Developer Mode) and because the usage text uses
PHP_EOL(\r\n) where the testexpects
\n. Verified by A/B: stashing this change and runningcomposer installback to1.0.0-rc.8produces the identical result,Tests: 27, Assertions: 66, Failures: 8, Warnings: 2forthat class, so the bump changes nothing here. No test or production class was renamed or weakened.
Notes
composerreportsPKSA-g499-cm4q-v35yforsymfony/filesystem8.1.9. This is pre-existing andits exit status is unstable across runs.
Read webware-ci.json). All checks pass on this PR:Mago (PHP 8.4, 8.5), the test matrix (PHP 8.4 and 8.5 against latest, locked, and lowest
dependencies), mutation testing, and Codecov. The patch is
composer.jsonpluscomposer.lockonly, so there is no code patch for the 95 percent patch target to measure.