Repository navigation
chore(deps): replace laminas-config-aggregator with webware-configmanager - #67
Merged
Merged
Conversation
…ager The aggregator is a drop-in replacement: the constructor takes the same arguments in the same order and getMergedConfig() returns the same array, so only the imports move. The provider list and its order are unchanged. Forced lock movement: webware-configmanager requires brick/varexporter ^0.7.0 and laminas/laminas-servicemanager 4.5.1 caps varexporter at ^0.6.0, so servicemanager moves to 4.6.0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical swap
laminas/laminas-config-aggregatoris replaced bywebware/webware-configmanager^1.0.0-alpha.4.The replacement is a drop-in: the constructor takes the same arguments in the same order,
getMergedConfig()returns the same array, andArrayProviderandPhpFileProviderhave directequivalents. Parity is already covered by
webware-configmanager'stest/integration/LaminasConfigAggregatorParityTest.php, so this pull request does not re-prove it.Touch points:
composer.json: the requirement is swapped.config/config.php:ArrayProvider,ConfigAggregatorandPhpFileProviderimports. Providerlist, its order and its comments are unchanged.
config/autoload/global.php:ConfigAggregator::ENABLE_CACHEbecomesConfigCache::ENABLE_CACHE.config/development.config.php.dist: the same constant.dev:mode --enablecopies this file toconfig/development.config.php, whichconfig/config.phpaggregates, so leaving the Laminasreference there would throw a class-not-found as soon as development mode is enabled.
test/integration/Application/CommandRegistrationIntegrationTest.php: the two imports only, nobehavioural change.
No wrapper, adapter or shim was added, and no gate was given a baseline or suppression entry.
Forced lock movement
webware-configmanagerrequiresbrick/varexporter ^0.7.0.laminas/laminas-servicemanager4.5.1requires
brick/varexporter ^0.3.8 || ^0.4.0 || ^0.5.0 || ^0.6.0, so it cannot stay. Measured, notassumed:
Every lock entry that moved, and whether it was forced:
Nothing else moved. The lock was produced with
composer update ... --minimal-changes, and a fullcomposer updatewas discarded because it also re-resolved unrelated packages.php-standard-library/*did not move fromrequire-devtorequire:php-standard-library/terminalwas already a runtime requirement, and
type,file,filesystemandcollectionarrive astransitive runtime dependencies.
Gates
phpunit: 147 tests, 8 failures. All 8 are inDevelopmentModeCommandTestand reproduce on theunmodified baseline in this Windows checkout (symlink creation and CRLF expectations), so they are
not caused by this change and were not touched.
mago analyze: no issues.mago guard: no issues.mago lint: no issues in the touched files. 71 warnings exist repo-wide, all in files this changedoes not touch.
mago format --check: the touched files are formatted. Two other files repo-wide are not, and theyare unformatted on the baseline too.
ENABLE_CACHE => true,php bin/webware listwritesdata/cache/config-cache.php. Withconfig/development.config.phpin place, the same commandwrites no cache file.
Follow-up
webware-configmanagersupports#[LoadAfter]and#[LoadBefore]for provider ordering. Notadopted here, because this pull request keeps the provider list exactly as it was. Adopting them is a
separate change.
CI
The Continuous Integration run is fully green on this head: Mago (PHP 8.4), Mago (PHP 8.5),
Test (PHP 8.4 and 8.5, each on latest, locked and lowest), Mutation testing, Codecov and
codecov/patch.