Skip to content

node 24 compatibility and update vulnerable packages#40

Open
vlinder wants to merge 2 commits intowebos-tools:mainfrom
vlinder:vlinder/update-dependencies
Open

node 24 compatibility and update vulnerable packages#40
vlinder wants to merge 2 commits intowebos-tools:mainfrom
vlinder:vlinder/update-dependencies

Conversation

@vlinder
Copy link
Copy Markdown

@vlinder vlinder commented Apr 29, 2026

  • Updates ssh2 to assure node 24 compatibility.
  • Update packages to fix vulnerabilities.
  • Refactor to remove deprecated request package with vulnerabilities.

Notes:

  • Could not successfully run all jasmine tests because emulator won't start on apple silicon mac.
  • Did not update dev dependencies.

@regan-karlewicz
Copy link
Copy Markdown

regan-karlewicz commented Apr 30, 2026

I would love to see Node 24 support here now that Node 20 LTS is at EOL. I couldn't get this package to work on Node 22: #15 (comment)

@vlinder
Copy link
Copy Markdown
Author

vlinder commented May 4, 2026

I would love to see Node 24 support here now that Node 20 LTS is at EOL. I couldn't get this package to work on Node 22: #15 (comment)

Not sure if I did anything special. But node 22 has been working well for us.

Now that we updated to 24 we had to override the ssh2 dependency in our package.json. (See below) Having this PR merged would be nice to get rid of both many vulnerabilities and also this override.

{
  "devDependencies": {
    "@webos-tools/cli": "3.2.3"
  }
  "pnpm": {
    "overrides": {
      "ssh2@<1.16.0": "^1.16.0"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants