node 24 compatibility and update vulnerable packages#40
Open
vlinder wants to merge 2 commits intowebos-tools:mainfrom
Open
node 24 compatibility and update vulnerable packages#40vlinder wants to merge 2 commits intowebos-tools:mainfrom
vlinder wants to merge 2 commits intowebos-tools:mainfrom
Conversation
|
I would love to see Node 24 support here now that Node 20 LTS is at EOL. I couldn't get this package to work on Node 22: #15 (comment) |
Author
Not sure if I did anything special. But node 22 has been working well for us. Now that we updated to 24 we had to override the ssh2 dependency in our package.json. (See below) Having this PR merged would be nice to get rid of both many vulnerabilities and also this override. {
"devDependencies": {
"@webos-tools/cli": "3.2.3"
}
"pnpm": {
"overrides": {
"ssh2@<1.16.0": "^1.16.0"
}
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssh2to assure node 24 compatibility.requestpackage with vulnerabilities.Notes: