Fix Linux simulator launch for AppImage files#41
Open
riordant wants to merge 1 commit intowebos-tools:developfrom
Open
Fix Linux simulator launch for AppImage files#41riordant wants to merge 1 commit intowebos-tools:developfrom
riordant wants to merge 1 commit intowebos-tools:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:Release Notes:
Fix Linux webOS TV Simulator detection and launch when the simulator executable uses the standard
.AppImageextension casing.:Detailed Notes:
On Linux, webOS TV 26 Simulator is distributed as a file named like:
webOS_TV_26_Simulator_1.5.0.AppImage
The existing simulator discovery checks
path.extname(filePath)against.appimagecase-sensitively, so.AppImagefiles are ignored.Additionally, the launch step reconstructs the executable path using a lowercase
.appimageextension, which also fails on case-sensitive Linux filesystems.This change:
.toLowerCase():Testing Performed:
@webos-tools/clion Linux using Node 16.ares-launch -s 26 -sp <simulator-dir> <app-dir>fails before the patch when the simulator file is named.AppImage.:Issues Addressed:
N/A