Repository navigation
fix: parse process substitution targets in combined redirects - #22
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
`cmd &> >(tee log)` currently reports a missing redirect target and treats the process substitution as another argument. The same happens with `&>>` and `<(...)` targets. Use the existing balanced-target handling for these combined redirects. The tests cover both directions, adjacent tokens, incomplete targets, nested diagnostics and printing. Concatenating a process substitution with more text keeps the existing limitation discussed in webpro-nl#19. All 2,074 tests, type checks, build and formatting passed. Lint passed with the same four existing warnings. Bash 5.1 accepted the 19 valid inputs and their printed output, and the runtime smoke passed on Node 14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd &> >(tee log)currently reports a missing redirect target and treats the process substitution as another argument. The same happens with&>>and<(...)targets.Use the existing balanced-target handling for these combined redirects. The tests cover both directions, adjacent tokens, incomplete targets, nested diagnostics and printing. Concatenating a process substitution with more text keeps the existing limitation discussed in #19.
All 2,074 tests, type checks, build and formatting passed. Lint passed with the same four existing warnings. Bash 5.1 accepted the 19 valid inputs and their printed output, and the runtime smoke passed on Node 14.