Repository navigation
fix: scan consecutive test comments without recursion - #24
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
A long sequence of comment lines inside [[ ... ]] could exhaust the call stack before reaching the expression. Scan those comments in a loop while keeping ordinary newline tokens, token offsets and pending heredocs intact. Add a 20,000-comment regression and preservation cases for CRLF, lexer windows, embedded hashes and heredocs. All 2,064 tests pass across the test files, along with build, typecheck, lint and formatting. The five focused tests also pass as compiled JavaScript on Node 20; the source tests ran on Node 24. Bash accepts and executes the same large input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long sequence of comment lines inside [[ ... ]] could exhaust the call stack before reaching the expression. Scan those comments in a loop while keeping ordinary newline tokens, token offsets and pending heredocs intact.
Add a 20,000-comment regression and preservation cases for CRLF, lexer windows, embedded hashes and heredocs. All 2,064 tests pass across the test files, along with build, typecheck, lint and formatting. The five focused tests also pass as compiled JavaScript on Node 20; the source tests ran on Node 24. Bash accepts and executes the same large input.