Repository navigation
fix: recognize operators across line continuations - #25
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
Bash removes backslash-newline pairs before recognizing operators. Splitting an operator across lines could make unbash read it as separate tokens or a different redirection. Skip continuations while looking ahead for control and redirection operators, preserving physical source offsets. The regression cases check token spans, parsing and printing, with Bash as a syntax and behavior oracle. The Node 24 suite passed 2,204 tests with 14 cases skipped because the host has Bash 3.2. The focused suite passed on Node 24 and compiled Node 20. A separate Bash 5.1.4 run covered 52 variants with 312 passing checks. Build, typecheck, lint and formatting passed; Node 14 was not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash removes backslash-newline pairs before recognizing operators. Splitting an operator across lines could make unbash read it as separate tokens or a different redirection.
Skip continuations while looking ahead for control and redirection operators, preserving physical source offsets. The regression cases check token spans, parsing and printing, with Bash as a syntax and behavior oracle.
The Node 24 suite passed 2,204 tests with 14 cases skipped because the host has Bash 3.2. The focused suite passed on Node 24 and compiled Node 20. A separate Bash 5.1.4 run covered 52 variants with 312 passing checks. Build, typecheck, lint and formatting passed; Node 14 was not run.