Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vendor/wheels/auth/JwtService.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ component output="false" {
local.signingInput = local.parts[1] & "." & local.parts[2];
local.expectedSig = $sign(local.signingInput);

if (local.expectedSig != local.parts[3]) {
if (!CreateObject("java", "java.security.MessageDigest").isEqual(
local.expectedSig.getBytes("UTF-8"),
local.parts[3].getBytes("UTF-8")
)) {
throw(
type = "Wheels.Auth.JWT.InvalidSignature",
message = "JWT signature verification failed"
Expand Down
13 changes: 13 additions & 0 deletions vendor/wheels/tests/specs/auth/JwtServiceSpec.cfc
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,19 @@ component extends="wheels.WheelsTest" {
expect(claims.sub).toBe(1);
});

it("rejects a token whose signature differs by a single character", function() {
var token = jwt.encode(claims = {sub = 99});
var parts = ListToArray(token, ".");
var sig = parts[3];
var lastChar = Right(sig, 1);
var flipped = lastChar == "A" ? "B" : "A";
parts[3] = Left(sig, Len(sig) - 1) & flipped;
var tampered = ArrayToList(parts, ".");
expect(function() {
jwt.decode(token = tampered);
}).toThrow("Wheels.Auth.JWT.InvalidSignature");
});

it("still validates signature when ignoreExpiry is true", function() {
var otherJwt = new wheels.auth.JwtService(secretKey = "wrong-key");
var now = Int(CreateObject("java", "java.lang.System").currentTimeMillis() / 1000);
Expand Down
Loading