fix(middleware): default rate limiter proxy strategy to last for security#2088
Merged
fix(middleware): default rate limiter proxy strategy to last for security#2088
Conversation
…rity Change proxyStrategy default from "first" (spoofable leftmost IP) to "last" (rightmost proxy-appended IP) when trustProxy is enabled. This prevents attackers from bypassing rate limiting via X-Forwarded-For header spoofing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…te method The test was calling $getClientKey which doesn't exist. Rewrite to use handle() and verify rate limiting behavior proves the default strategy is "last" (same last IP = same bucket = blocked on second request). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxyStrategydefault from"first"(spoofable leftmost IP) to"last"(rightmost proxy-appended IP) whentrustProxyis enabledTest plan
bash tools/test-local.sh middleware🤖 Generated with Claude Code