Repository navigation
fix(build): clean the extensions with the pg_config of each major (upstream #1174) - #6
Merged
Merged
Conversation
arthlr
self-requested a review
October 8, 2026 15:17
arthlr
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream zalando/spilo 84ab386 (zalando#1174).
base.sh runs `make clean` for every major with the first `pg_config` in PATH (PostgreSQL 17), so an extension built from source can keep objects compiled for another major. Whether it happens depends on file timestamps during the build: the CI image sometimes ships a `bg_mon.so` for PostgreSQL 17 built against another major, and the in-place upgrade tests fail at random with:
```
FATAL: incompatible library "/usr/lib/postgresql/17/lib/bg_mon.so": version mismatch
```
Seen in the failed runs of #1 and #2 (upgrades to 16 and to 17), captured with a temporary log dump in #5.