Closed
Conversation
Timer can fire after the entity has been removed
Contributor
|
Unfortunately, this isn't a solution. The problem is deeper and lies in the fact that the destruct hook isn't being called (i should fix it someday) |
wrefgtzweve
approved these changes
Mar 9, 2026
Member
True but in the meanwhile it shouldn't error, i think |
Contributor
|
I'll try to fix the root of the issue today, if that doesn't work then i'll just merge this pr |
Contributor
|
Also, adding a simple IsValid won't remove the buggy timers on error, which is even worse. So, i'd better close the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timer can fire after the entity has been removed
Error variable trace (ignore the stdout color control chars)