Rename Dilithium API to ML-DSA and make CI track latest wolfSSL stable#33
Merged
Conversation
aidangarske
changed the title
aidangarske
added a commit
to aidangarske/wolfCOSE
that referenced
this pull request
May 30, 2026
CI failures on PR wolfSSL#33 were runtime, not compile: the Examples and Scenarios jobs built the demo/scenario binaries (linked against the shared libwolfssl) but ran them without LD_LIBRARY_PATH, so they failed with "libwolfssl.so.44: cannot open shared object file". Export LD_LIBRARY_PATH in the run step for both workflows. Review follow-ups: - multi-compiler.yml: make the compiler list a real matrix axis so it cross-products with the wolfSSL ref (6 compilers x 2 refs) instead of collapsing via include-merge. - sanitizer.yml: drop the "|| true" that masked forced-failure / ASan regressions in the coverage-force-failure step. - tools/wolfcose_tool.c: check wc_MlDsaKey_Init / wc_MlDsaKey_SetParams return codes in keygen/sign/verify before using the key instead of proceeding on a possibly-uninitialized key. - tools/wolfcose_tool.c: the verify command returned 1 on the success path (pre-existing); return 0 so a successful ML-DSA verify exits zero.
aidangarske
changed the title
aidangarske
added a commit
to aidangarske/wolfCOSE
that referenced
this pull request
Jun 1, 2026
CI failures on PR wolfSSL#33 were runtime, not compile: the Examples and Scenarios jobs built the demo/scenario binaries (linked against the shared libwolfssl) but ran them without LD_LIBRARY_PATH, so they failed with "libwolfssl.so.44: cannot open shared object file". Export LD_LIBRARY_PATH in the run step for both workflows. Review follow-ups: - multi-compiler.yml: make the compiler list a real matrix axis so it cross-products with the wolfSSL ref (6 compilers x 2 refs) instead of collapsing via include-merge. - sanitizer.yml: drop the "|| true" that masked forced-failure / ASan regressions in the coverage-force-failure step. - tools/wolfcose_tool.c: check wc_MlDsaKey_Init / wc_MlDsaKey_SetParams return codes in keygen/sign/verify before using the key instead of proceeding on a possibly-uninitialized key. - tools/wolfcose_tool.c: the verify command returned 1 on the success path (pre-existing); return 0 so a successful ML-DSA verify exits zero.
Frauschi
requested changes
Jun 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aidangarske
force-pushed
the
mldsa-rename
branch
2 times, most recently
from
9204913 to
d896716
Compare
aidangarske
added
enhancement
dgarske
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_MlDsaKey