Add WOLFCOSE_LEAN config layer with WOLFCOSE_HAVE_* feature gates#42
Merged
Conversation
8c6fb18 to
2a43b20
Compare
2a43b20 to
2a4a7f1
Compare
33b0c75 to
1000ac9
Compare
1000ac9 to
06637d1
Compare
mattia-moffa
requested changes
Jun 4, 2026
Member
mattia-moffa
left a comment
There was a problem hiding this comment.
There still seem to be references to raw HAVE_ECC which should probably be WOLFCOSE_HAVE_ECDSA: src/wolfcose.c at lines 4072, 4241, 4669 (the latter two also call wolfCose_EccSignRaw / wolfCose_EccVerifyRaw which are only defined with WOLFCOSE_HAVE_ECDSA).
Also WOLFCOSE_HAVE_CHACHA20/AESCCM/HMAC384/HMAC512/AESMAC seem to only be used in the tests and examples, not in the source.
06637d1 to
ab4f77e
Compare
mattia-moffa
approved these changes
Jun 4, 2026
…FCOSE_HAVE_* feature macros
ab4f77e to
2964637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WOLFCOSE_LEAN: core-only build (Sign1/Encrypt0/Mac0 + ES256/AES-GCM/HMAC-256)WOLFCOSE_ENABLE_<X>;WOLFCOSE_ENABLE_ALLenables allinclude/wolfcose/settings.hresolves config intoWOLFCOSE_HAVE_*flags#errorWOLFCOSE_HAVE_*, so leanmake testruns only enabled algos#errorguards added