Skip to content

fwTPM/wolfTPM testing and hardening#518

Merged
dgarske merged 50 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-14
Jun 3, 2026
Merged

fwTPM/wolfTPM testing and hardening#518
dgarske merged 50 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-14

Conversation

@aidangarske
Copy link
Copy Markdown
Member

@aidangarske aidangarske commented Jun 2, 2026 •
edited
Loading

Description

F-4161, F-4673, F-4675, F-4677, F-4840, F-4841, F-4842, F-4843, F-4845, F-4846,
F-4847, F-4848, F-4953, F-4954, F-4955, F-4956, F-5015, F-5095, F-5096, F-5097,
F-5098, F-5099, F-5101, F-5102, F-5103, F-5104, F-5105, F-5106, F-5107, F-5108,
F-5109, F-5118, F-5119, F-5120, F-5122, F-5123, F-5124, F-5125, F-5127, F-5277,
F-5278, F-5279, F-5280, F-5281, F-5643, F-5644, F-5646, F-5647, F-5648, F-5649,
F-5653, F-5654, F-5655, F-5677, F-5678, F-5679, F-5719, F-5721, F-5722, F-5723,
F-5831, F-5832, F-5833, F-5834

Copilot AI review requested due to automatic review settings June 2, 2026 21:37
@aidangarske aidangarske changed the title fwTPM/wolfTPM Fenrir High + Medium security fixes fwTPM/wolfTPM testing and hardening Jun 2, 2026

This comment was marked as resolved.

Sign in to view

wolfSSL-Fenrir-bot

This comment was marked as resolved.

Sign in to view

@aidangarske aidangarske self-assigned this Jun 3, 2026
@aidangarske aidangarske marked this pull request as ready for review June 3, 2026 17:31
aidangarske added 22 commits June 3, 2026 10:36
@aidangarske
F-5097 F-5103 F-5831 - Enforce decrypt attribute on ECDH commands
eb359d3
@aidangarske
F-5120 - Reject TPM_RH_NULL and non-storage newParent in Rewrap
d7beca2
@aidangarske
F-5104 - Require restricted signing key in fwTPM Quote
a62c5b1
@aidangarske
F-4841 F-5832 - Enforce NV read authorization in PolicyNV and PolicyA…
991ae59 
…uthorizeNV
@aidangarske
F-5654 F-5655 - Validate selftest params and report test status
cb32e61
@aidangarske
F-5721 - Enforce DRTM PCR locality in fwTPM PCR_Event
84705f0
@aidangarske
F-5719 - Bind and enforce PolicyLocality constraint on policy sessions
9245b19
@aidangarske
F-5677 - Reject newMaxTries=0 in DictionaryAttackParameters
b1a4528
@aidangarske
F-5722 - Enforce per-hierarchy persistent sub-range in EvictControl
4e7c88b
@aidangarske
F-4953 F-5095 - Enforce key-declared signing scheme over wire scheme
6f3c20f
@aidangarske
F-5280 - Reject non-session response tag for sessioned commands
ef59e32
@aidangarske
F-5647 - Reject negative authSz in key auth wrapper APIs
9df47ef
@aidangarske
F-4840 - Require non-empty session key for parameter encryption
b8cdf54
@aidangarske
F-4842 F-5098 - Sanitize NV journal DA maxTries and object handle
6ee4582
@aidangarske
F-5678 - Populate attestation clockInfo from live TPM state
c03db2d
@aidangarske
F-4673 - Bind context sequence counter to blob and reject replay
60aef67
@aidangarske
F-5101 F-5108 - Flush transient state on command client change
2f059c3
@aidangarske
F-5102 F-5119 F-5833 - Authenticate NV journal with integrity MAC
6c9a64e
@aidangarske
F-5646 - Document empty-auth risk on key load/import helpers
89eb045
@aidangarske
F-5105 F-5106 F-5107 - Require signing key for attestation commands
77f5022
@aidangarske
F-4845 F-4848 F-5096 F-5015 - Enforce key scheme/hash in RSA and HMAC
e98e527
@aidangarske
F-4956 F-4846 - Enforce tpmKey decrypt attr and cipher mode match
7a4b94e
aidangarske added 23 commits June 3, 2026 10:36
@aidangarske
F-5277 F-5122 - Store and enforce policy cpHashA command binding
5617f43
@aidangarske
F-5278 F-5723 - Exempt NO_DA NV from lockout and persist GlobalWriteLock
194d3bf
@aidangarske
F-5834 F-5281 F-5118 - Fix ephemeral DoS and PKCS1 unpad OOB/padding
32a823c
@aidangarske
F-4161 F-4843 - Reject oversized auth and undersized session nonce
204573f
@aidangarske
F-4954 - Require TPM_RH_NULL hierarchy for LoadExternal private key
5f8c180
@aidangarske
F-4955 - Derive credential keys under EK nameAlg not hardcoded SHA-256
c6b15aa
@aidangarske
F-4847 - Require inner-wrap path for encryptedDuplication objects
6332a9b
@aidangarske
F-5653 F-5644 - Bounds-check NV key read and propagate NV load errors
0f15767
@aidangarske
F-5123 F-5124 - fsync NV writes for crash durability
944058a
@aidangarske
F-4675 F-4677 F-5125 - Harden fwTPM command-port signals and shm perms
4ac2bd2
@aidangarske
F-5643 - Skip DER decode when PEM-to-DER conversion fails
4a874c6
@aidangarske
F-5127 - Guard wolfSPDM_Finish against missing KeyExchange state
ef022dd
@aidangarske
F-5648 F-5649 - Add HMAC verify truncation and compute buffer-size tests
3493055
@aidangarske
F-5654 F-5719 F-5277 F-5122 F-4845 F-4955 - Harden fwTPM fixes per re…
5453e6f 
…view
@aidangarske
F-5655 - Parse GetTestResult testResult as full 32-bit value
d7638f9
@aidangarske
F-4161 - Reject oversized auth in CreateLoadedKey and CreatePrimaryKey
d42f610
@aidangarske
F-4677 - Drop dead command-port power-signal branches
684de58
@aidangarske
F-5102 - Create NV journal key file with O_EXCL and O_NOFOLLOW
675d336
@aidangarske
F-4673 - Track live context sequences for any-order single-use load
57f49c7
@aidangarske
fwtpm: keep transient state across command-port reconnects
bf01067
@aidangarske
fwtpm: address PR review for scheme checks, context-save, and NV dura…
16a4741 
…bility
@aidangarske
F-5835, F-5100 - Validate firmware data-size bound and NV reserved at…
61f7fec 
…tribute bits
@aidangarske
fwtpm: scope context replay to sessions and accept unsalted param-enc
5699061
@aidangarske aidangarske requested a review from dgarske June 3, 2026 19:08
@dgarske dgarske merged commit 519e760 into wolfSSL:master Jun 3, 2026
153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments

@dgarske dgarske dgarske approved these changes

Assignees

@aidangarske aidangarske

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aidangarske @dgarske @wolfSSL-Fenrir-bot