Update wordpress:utils 3.5.0 -> 3.15.0#1119
Open
ygnessin wants to merge 1 commit intowordpress-mobile:trunkfrom
Open
Update wordpress:utils 3.5.0 -> 3.15.0#1119ygnessin wants to merge 1 commit intowordpress-mobile:trunkfrom
ygnessin wants to merge 1 commit intowordpress-mobile:trunkfrom
Conversation
Author
|
@zwarm It looks like you are the most recent contributor to this project. Can you help land this PR? |
Contributor
Hi @ygnessin, thanks for the contribution! I’ll need to take a deeper look at how this change could impact the apps currently using this library before moving forward. The utils haven’t been updated since 2024, and quite a bit has changed since then. This review may take some time as I’m currently focused on higher-priority work, but I’ll share an update as soon as I’m able to dig in. 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Updates the
wordpress:utilsdependency to the latest: https://github.com/wordpress-mobile/WordPress-Utils-Android/releasesPrimary motivation is that the GET_ACCOUNTS permission gets pulled into any apps using Aztec. This was fixed in version 3.8.0 of
wordpress:utils.Many other dependencies are severely out of date as well, hopefully there is a plan to update them at some point.
Test
Ran all unit tests and they passed
Review
??? Not sure