Repository navigation
fix: count design periods at their actual deadlines - #3
Draft
1932819331hy-debug wants to merge 1 commit into
Draft
1932819331hy-debug wants to merge 1 commit into
1932819331hy-debug wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix both sides of an ordinary fractional-rate boundary:
Check the next and already-counted deadlines without an epsilon or loop. Keep the existing
intendedEndarithmetic, input rules, RPC behavior and other report fields unchanged.Evidence
13184ff111532c172f37d54d59f00e7eea6b9a23.After: all 22 pass; native
npm testpasses 45/45.Numerical limit: the broader decimal-millisecond diagnostic still fails with 768 discrepancies among 37,800 cases at low/zero origins. It compares independently rounded decimal totals with the library's existing binary operation order. This patch preserves the observable
intendedEndconvention. The separate reported-deadline consistency sample passes, but this is not a full-domain precision claim.All execution used Node 24.22.1 and synthetic in-memory transport. Node 18/20/22, other operating systems, live RPC, actual CLI/Action execution and hosted CI remain unverified. Build, lint and typecheck scripts are not configured.
AI assistance was used for implementation, testing and independent review. This is a source-backed contract repair, not completion of a separate maintainer issue.
Merge Danger
Door: Two-way. A localized arithmetic correction with no migration.
Blast Radius: Reporting.
Expected-period and periods-ahead counts can change by one at the demonstrated boundaries. Deadline values and numeric policy are unchanged.