Repository navigation
fix: read the package list of cmdline-tools 23 - #26
Merged
Merged
Conversation
sdkmanager 23 prints the package list without "|" between the columns and
with "/" in the ids ("platforms/android-37.0"). listInstalledPackages split
on "|", so it returned nothing and every package looked missing. That made
setup offer to reinstall what was installed, and --check, --update and
--prune work from wrong data.
packageColumns() now reads both formats and always returns the id with ";".
listInstalledPackages and parseUpdates use it.
wswebcreation
added
PR: Bug Fix 🐛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdkmanager 23 prints the package list without "|" between the columns and with "/" in the ids ("platforms/android-37.0"). listInstalledPackages split on "|", so it returned nothing and every package looked missing. That made setup offer to reinstall what was installed, and --check, --update and --prune work from wrong data.
packageColumns() now reads both formats and always returns the id with ";". listInstalledPackages and parseUpdates use it.