Skip to content

test(cli,web): raise coverage for workspace switch paths #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wynxing merged 1 commit into from
May 17, 2026
Merged

test(cli,web): raise coverage for workspace switch paths #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
359 changes: 359 additions & 0 deletions internal/cli/web_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
package cli

import (
"bytes"
"context"
"encoding/json"
"errors"
"io/fs"
"log"
"net"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"strings"
"testing"
"testing/fstest"
"time"
)

// writeWebCommandTestFile 写入 web 命令测试所需的最小文件内容，避免各测试重复拼装目录。
Expand Down Expand Up @@ -286,3 +292,356 @@ func TestRunWebCommandSkipBuildStillUsesEmbeddedAssets(t *testing.T) {
t.Fatal("startGatewayServer staticFS = nil, want embedded assets FS")
}
}

func TestValidateStaticDirAndResolveOverride(t *testing.T) {
tempDir := t.TempDir()
staticDir := filepath.Join(tempDir, "dist")
if _, err := validateStaticDir(staticDir); err == nil {
t.Fatal("validateStaticDir() error = nil, want missing index.html error")
}

writeWebCommandTestFile(t, filepath.Join(staticDir, "index.html"), "<html></html>")
got, err := resolveWebStaticDir(staticDir)
if err != nil {
t.Fatalf("resolveWebStaticDir() error = %v", err)
}
if got != staticDir {
t.Fatalf("resolveWebStaticDir() = %q, want %q", got, staticDir)
}

dirIndex := filepath.Join(tempDir, "bad-dist", "index.html")
if err := os.MkdirAll(dirIndex, 0o755); err != nil {
t.Fatalf("mkdir %s: %v", dirIndex, err)
}
if _, err := validateStaticDir(filepath.Dir(dirIndex)); err == nil || !strings.Contains(err.Error(), "is a directory") {
t.Fatalf("validateStaticDir() error = %v, want directory error", err)
}
}

func TestIsStaleFrontendBuildBranches(t *testing.T) {
tempDir := t.TempDir()
webDir := filepath.Join(tempDir, "web")
srcDir := filepath.Join(webDir, "src")
distIndex := filepath.Join(webDir, "dist", "index.html")

if !isStaleFrontendBuild(webDir) {
t.Fatal("isStaleFrontendBuild() = false, want true when dist is missing")
}

writeWebCommandTestFile(t, distIndex, "<html></html>")
writeWebCommandTestFile(t, filepath.Join(webDir, "package.json"), "{}")
writeWebCommandTestFile(t, filepath.Join(webDir, "vite.config.ts"), "export default {}")
writeWebCommandTestFile(t, filepath.Join(webDir, "tsconfig.json"), "{}")
writeWebCommandTestFile(t, filepath.Join(srcDir, "main.ts"), "console.log('ok')")

distTime := time.Now()
if err := os.Chtimes(distIndex, distTime, distTime); err != nil {
t.Fatalf("chtimes dist: %v", err)
}
olderTime := distTime.Add(-time.Minute)
for _, path := range []string{
filepath.Join(webDir, "package.json"),
filepath.Join(webDir, "vite.config.ts"),
filepath.Join(webDir, "tsconfig.json"),
filepath.Join(srcDir, "main.ts"),
} {
if err := os.Chtimes(path, olderTime, olderTime); err != nil {
t.Fatalf("chtimes %s: %v", path, err)
}
}

if isStaleFrontendBuild(webDir) {
t.Fatal("isStaleFrontendBuild() = true, want false when dist is newest")
}

newerTime := distTime.Add(time.Minute)
packageJSON := filepath.Join(webDir, "package.json")
if err := os.Chtimes(packageJSON, newerTime, newerTime); err != nil {
t.Fatalf("chtimes package.json: %v", err)
}
if !isStaleFrontendBuild(webDir) {
t.Fatal("isStaleFrontendBuild() = false, want true when package.json is newer")
}

if err := os.Chtimes(packageJSON, olderTime, olderTime); err != nil {
t.Fatalf("restore package.json time: %v", err)
}
srcFile := filepath.Join(srcDir, "main.ts")
if err := os.Chtimes(srcFile, newerTime, newerTime); err != nil {
t.Fatalf("chtimes src: %v", err)
}
if !isStaleFrontendBuild(webDir) {
t.Fatal("isStaleFrontendBuild() = false, want true when src file is newer")
}
}

func TestBuildFrontendAndReadGatewayToken(t *testing.T) {
tempDir := t.TempDir()
webDir := filepath.Join(tempDir, "web")
if err := os.MkdirAll(webDir, 0o755); err != nil {
t.Fatalf("mkdir webdir: %v", err)
}

npmPath := filepath.Join(tempDir, "npm")
script := strings.Join([]string{
"#!/bin/sh",
"set -eu",
"if [ \"$1\" = \"install\" ]; then",
" exit 0",
"fi",
"if [ \"$1\" = \"run\" ] && [ \"$2\" = \"build\" ]; then",
" mkdir -p \"$PWD/dist\"",
" printf '<html></html>' > \"$PWD/dist/index.html\"",
" exit 0",
"fi",
"exit 1",
}, "\n")
if err := os.WriteFile(npmPath, []byte(script), 0o755); err != nil {
t.Fatalf("write npm stub: %v", err)
}
stubWebCommandHooks(t, nil, nil, func(string) (string, error) {
return npmPath, nil
})

logger := log.New(&bytes.Buffer{}, "", 0)
if err := buildFrontend(webDir, logger); err != nil {
t.Fatalf("buildFrontend() error = %v", err)
}
if _, err := os.Stat(filepath.Join(webDir, "dist", "index.html")); err != nil {
t.Fatalf("built dist/index.html missing: %v", err)
}

homeDir := filepath.Join(tempDir, "home")
authDir := filepath.Join(homeDir, ".neocode")
if err := os.MkdirAll(authDir, 0o755); err != nil {
t.Fatalf("mkdir auth dir: %v", err)
}
authData, err := json.Marshal(map[string]string{"token": " secret-token "})
if err != nil {
t.Fatalf("marshal auth data: %v", err)
}
if err := os.WriteFile(filepath.Join(authDir, "auth.json"), authData, 0o644); err != nil {
t.Fatalf("write auth.json: %v", err)
}
originalHome := os.Getenv("HOME")
if err := os.Setenv("HOME", homeDir); err != nil {
t.Fatalf("set HOME: %v", err)
}
t.Cleanup(func() {
_ = os.Setenv("HOME", originalHome)
})
if got := readGatewayToken(); got != "secret-token" {
t.Fatalf("readGatewayToken() = %q, want %q", got, "secret-token")
}
}

func TestWaitForGatewayAndOpenBrowserAndResolveListenAddress(t *testing.T) {
tempDir := t.TempDir()
homeDir := filepath.Join(tempDir, "home")
authDir := filepath.Join(homeDir, ".neocode")
if err := os.MkdirAll(authDir, 0o755); err != nil {
t.Fatalf("mkdir auth dir: %v", err)
}
authData, err := json.Marshal(map[string]string{"token": "token-123"})
if err != nil {
t.Fatalf("marshal auth data: %v", err)
}
if err := os.WriteFile(filepath.Join(authDir, "auth.json"), authData, 0o644); err != nil {
t.Fatalf("write auth.json: %v", err)
}
originalHome := os.Getenv("HOME")
if err := os.Setenv("HOME", homeDir); err != nil {
t.Fatalf("set HOME: %v", err)
}
t.Cleanup(func() {
_ = os.Setenv("HOME", originalHome)
})

binDir := filepath.Join(tempDir, "bin")
if err := os.MkdirAll(binDir, 0o755); err != nil {
t.Fatalf("mkdir bin dir: %v", err)
}
openLog := filepath.Join(tempDir, "opened-url.txt")
scriptPath := filepath.Join(binDir, "xdg-open")
script := "#!/bin/sh\nprintf '%s' \"$1\" > \"" + openLog + "\"\n"
if err := os.WriteFile(scriptPath, []byte(script), 0o755); err != nil {
t.Fatalf("write xdg-open stub: %v", err)
}
originalPath := os.Getenv("PATH")
if err := os.Setenv("PATH", binDir+string(os.PathListSeparator)+originalPath); err != nil {
t.Fatalf("set PATH: %v", err)
}
t.Cleanup(func() {
_ = os.Setenv("PATH", originalPath)
})

server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path != "/healthz" {
http.NotFound(w, r)
return
}
w.WriteHeader(http.StatusOK)
}))
defer server.Close()

logger := log.New(&bytes.Buffer{}, "", 0)
waitForGatewayAndOpenBrowser(context.Background(), strings.TrimPrefix(server.URL, "http://"), logger)

var data []byte
var readErr error
for i := 0; i < 20; i++ {
data, readErr = os.ReadFile(openLog)
if readErr == nil {
break
}
time.Sleep(25 * time.Millisecond)
}
if readErr != nil {
t.Fatalf("read open log: %v", readErr)
}
if got := string(data); got != server.URL+"/?token=token-123" {
t.Fatalf("opened url = %q, want %q", got, server.URL+"/?token=token-123")
}

if got := resolveWebListenAddress("bad-address"); got != "bad-address" {
t.Fatalf("resolveWebListenAddress() = %q, want original invalid address", got)
}

listener, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatalf("listen: %v", err)
}
defer listener.Close()
occupied := listener.Addr().String()
resolved := resolveWebListenAddress(occupied)
if resolved == occupied {
t.Fatalf("resolveWebListenAddress() = %q, want fallback port", resolved)
}
}

func TestResolveWebStaticDirCurrentWorkdirAndReadGatewayTokenInvalid(t *testing.T) {
tempDir := t.TempDir()
chdirForWebCommandTest(t, tempDir)
writeWebCommandTestFile(t, filepath.Join(tempDir, "web", "dist", "index.html"), "<html></html>")
stubResolveExecutablePath(t, func() (string, error) {
return "", errors.New("skip executable lookup")
})

got, err := resolveWebStaticDir("")
if err != nil {
t.Fatalf("resolveWebStaticDir() error = %v", err)
}
if got != filepath.Join(tempDir, "web", "dist") {
t.Fatalf("resolveWebStaticDir() = %q, want cwd web/dist", got)
}

homeDir := filepath.Join(tempDir, "home")
authDir := filepath.Join(homeDir, ".neocode")
if err := os.MkdirAll(authDir, 0o755); err != nil {
t.Fatalf("mkdir auth dir: %v", err)
}
if err := os.WriteFile(filepath.Join(authDir, "auth.json"), []byte("{invalid"), 0o644); err != nil {
t.Fatalf("write invalid auth.json: %v", err)
}
originalHome := os.Getenv("HOME")
if err := os.Setenv("HOME", homeDir); err != nil {
t.Fatalf("set HOME: %v", err)
}
t.Cleanup(func() {
_ = os.Setenv("HOME", originalHome)
})
if got := readGatewayToken(); got != "" {
t.Fatalf("readGatewayToken() = %q, want empty on invalid json", got)
}
}

func TestRunWebCommandFallbackAndSkipBuildErrors(t *testing.T) {
tempDir := t.TempDir()
chdirForWebCommandTest(t, tempDir)
stubResolveExecutablePath(t, func() (string, error) {
return "", errors.New("skip executable lookup")
})
stubWebCommandEmbeddedAssets(t, nil, false)

err := runWebCommand(context.Background(), webCommandOptions{
HTTPAddress: "127.0.0.1:8080",
LogLevel: "info",
SkipBuild: true,
OpenBrowser: false,
Workdir: tempDir,
})
if err == nil || !strings.Contains(err.Error(), "--skip-build is set") {
t.Fatalf("runWebCommand() error = %v, want skip-build missing assets error", err)
}

writeWebCommandTestFile(t, filepath.Join(tempDir, "web", "package.json"), "{}")
err = runWebCommand(context.Background(), webCommandOptions{
HTTPAddress: "127.0.0.1:8080",
LogLevel: "info",
OpenBrowser: false,
Workdir: tempDir,
})
if err == nil || !strings.Contains(err.Error(), "frontend build failed on this machine") {
t.Fatalf("runWebCommand() error = %v, want build failure error", err)
}
}

func TestRunWebCommandRebuildsStaleDistAndDefaultsWorkdir(t *testing.T) {
tempDir := t.TempDir()
chdirForWebCommandTest(t, tempDir)
webDir := filepath.Join(tempDir, "web")
writeWebCommandTestFile(t, filepath.Join(webDir, "package.json"), "{}")
writeWebCommandTestFile(t, filepath.Join(webDir, "vite.config.ts"), "export default {}")
writeWebCommandTestFile(t, filepath.Join(webDir, "tsconfig.json"), "{}")
writeWebCommandTestFile(t, filepath.Join(webDir, "src", "main.ts"), "console.log('stale')")
writeWebCommandTestFile(t, filepath.Join(webDir, "dist", "index.html"), "<html></html>")

distIndex := filepath.Join(webDir, "dist", "index.html")
oldTime := time.Now().Add(-time.Hour)
newTime := time.Now()
if err := os.Chtimes(distIndex, oldTime, oldTime); err != nil {
t.Fatalf("chtimes dist: %v", err)
}
for _, path := range []string{
filepath.Join(webDir, "package.json"),
filepath.Join(webDir, "vite.config.ts"),
filepath.Join(webDir, "tsconfig.json"),
filepath.Join(webDir, "src", "main.ts"),
} {
if err := os.Chtimes(path, newTime, newTime); err != nil {
t.Fatalf("chtimes %s: %v", path, err)
}
}

buildCalled := false
var captured gatewayCommandOptions
sentinelErr := errors.New("stop after start")
stubWebCommandHooks(
t,
func(_ context.Context, options gatewayCommandOptions, _ string, _ fs.FS, _ func(string)) error {
captured = options
return sentinelErr
},
func(webDir string, _ *log.Logger) error {
buildCalled = true
writeWebCommandTestFile(t, filepath.Join(webDir, "dist", "index.html"), "<html></html>")
return nil
},
nil,
)

err := runWebCommand(context.Background(), webCommandOptions{
HTTPAddress: "127.0.0.1:8080",
LogLevel: "info",
OpenBrowser: false,
})
if !errors.Is(err, sentinelErr) {
t.Fatalf("runWebCommand() error = %v, want sentinel error", err)
}
if !buildCalled {
t.Fatal("runWebCommand() did not rebuild stale frontend dist")
}
if captured.Workdir != tempDir {
t.Fatalf("gateway workdir = %q, want cwd %q", captured.Workdir, tempDir)
}
}
Loading
Loading