fix: comingSoon in locator results#1226
Conversation
WalkthroughThis PR adds "coming soon" support to locator result cards. The Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
auto-screenshot-update: true
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/visual-editor/src/components/LocatorResultCard.tsx (1)
55-55: 💤 Low valueConsider using
.tsxextension for consistency.The import uses
.jsextension while other local imports in this file use.tsxor.ts. While this may be intentional for build system compatibility, it creates inconsistency.♻️ Proposed fix for consistency
-} from "./atoms/accordion.js"; +} from "./atoms/accordion.tsx";🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/visual-editor/src/components/LocatorResultCard.tsx` at line 55, The import from "./atoms/accordion.js" is inconsistent with other local imports in LocatorResultCard.tsx; update the import to use the .tsx extension (import from "./atoms/accordion.tsx") to match the file's TypeScript JSX convention and keep module resolution consistent, ensuring any tooling/configuration supports .tsx imports and adjusting exports in the Accordion component if needed (refer to the import statement referencing "./atoms/accordion.js" in LocatorResultCard.tsx).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/visual-editor/src/components/LocatorResultCard.tsx`:
- Line 55: The import from "./atoms/accordion.js" is inconsistent with other
local imports in LocatorResultCard.tsx; update the import to use the .tsx
extension (import from "./atoms/accordion.tsx") to match the file's TypeScript
JSX convention and keep module resolution consistent, ensuring any
tooling/configuration supports .tsx imports and adjusting exports in the
Accordion component if needed (refer to the import statement referencing
"./atoms/accordion.js" in LocatorResultCard.tsx).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 629c5b40-6a33-4517-9232-db4caba244f4
⛔ Files ignored due to path filters (4)
packages/visual-editor/src/components/testing/screenshots/ExpandedFooter/[mobile] version 48 props.pngis excluded by!**/*.png,!packages/visual-editor/src/components/testing/screenshots/**packages/visual-editor/src/components/testing/screenshots/Locator/[desktop] version 74 comingSoon.pngis excluded by!**/*.png,!packages/visual-editor/src/components/testing/screenshots/**packages/visual-editor/src/components/testing/screenshots/Locator/[mobile] version 74 comingSoon.pngis excluded by!**/*.png,!packages/visual-editor/src/components/testing/screenshots/**packages/visual-editor/src/components/testing/screenshots/Locator/[tablet] version 74 comingSoon.pngis excluded by!**/*.png,!packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (2)
packages/visual-editor/src/components/Locator.test.tsxpackages/visual-editor/src/components/LocatorResultCard.tsx
Same fix as #1225