Repository navigation
refactor!: 删 NewClientFromOAuthToken 兼容构造 - #16
Merged
Merged
Conversation
Deprecated 包级构造 NewClientFromOAuthToken 固定公网 base URL，私有部署 丢 URL 的坑已由 OAuthClient.NewClient（沿用 OAuthClient 的 base URL）修复； 旧构造零消费（仅示例注释提及），删除收口。示例注释同步改指 oauth.NewClient。 **BREAKING**：仓外若用 gitcode.NewClientFromOAuthToken(token)，改 oauth.NewClient(token)（私有部署必须用后者，否则客户端指向公网）。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
删 Deprecated 包级构造
NewClientFromOAuthToken(token)：它固定用公网 base URL，私有部署丢 URL 的坑已由OAuthClient.NewClient(token)（沿用 OAuthClient 的 base URL）修复。旧构造仓内零消费（仅 examples 注释提及），示例注释同步改指oauth.NewClient(token)。下游要做什么
验证：
make release-check全绿（build/vet/test -short）。