fix: prevent stderr from corrupting IME identifier in keyboard detection#396
Open
Ricardo-M-L wants to merge 1 commit into
Open
fix: prevent stderr from corrupting IME identifier in keyboard detection#396Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
`detect_and_set_adb_keyboard()` concatenates stdout and stderr when reading the current IME. If the adb/hdc command fails (e.g. permission denied), the error message pollutes the IME string, causing `restore_keyboard()` to receive an invalid identifier and silently fail to restore the original keyboard. Use only stdout when the command succeeds; fall back to empty string on failure. Affects both ADB (phone_agent/adb/input.py) and HarmonyOS (phone_agent/hdc/input.py) code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
detect_and_set_adb_keyboard()concatenatesstdout + stderrwhen reading the current IME:If the command fails (e.g. permission denied, device disconnected), the error message from stderr pollutes the IME string. This corrupted string is later passed to
restore_keyboard(), which silently fails to restore the original keyboard — leaving the device stuck on ADB Keyboard.Fix
Only use
stdoutwhen the command succeeds (returncode == 0); fall back to empty string on failure.Affects both:
phone_agent/adb/input.py(Android/ADB)phone_agent/hdc/input.py(HarmonyOS/HDC)