Repository navigation
fix: stop doctor from implying authentication - #48
Closed
zongqichen wants to merge 2 commits into
Closed
zongqichen wants to merge 2 commits into
zongqichen wants to merge 2 commits into
Conversation
This was referenced Nov 2, 2026
zongqichen
added a commit
that referenced
this pull request
Nov 2, 2026
## Why Doctor reported `ready` or `authenticated` for saved expired tokens because `cf target` can succeed without contacting Cloud Foundry. Its output now describes local configuration and states that authentication was not verified. ## What changed - Correct both complete-target and missing-org/space messages. - Add CLI regressions for text and JSON output and document the local diagnostic scope. ## Scope - Covers doctor output only. - Retains existing statuses, exit codes, and offline behavior. ## Blast Radius Users and JSON consumers receive more precise messages. Shared import checks and login behavior are unchanged. ## Verification - CLI regressions fail before the fix and pass afterward. - Official CF CLI tests with expired synthetic tokens confirm the corrected messages, unchanged no-token behavior, and zero API requests. - `make check`, `make release-check`, `make security`, and `make smoke` pass. Closes #56. Supersedes #48.
Owner
Author
|
Superseded by #57, which is now merged. The replacement corrects both doctor authentication claims on current main and preserves the Go security and test-isolation fixes. Independent official-CF verification and all PR checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A configured CF target does not prove that its access or refresh token is valid. Change the workspace-target doctor result from ready to configured; authentication not checked, add regression coverage, and document the fix. Validation: make check and make release-check.