Repository navigation
fix: render Work Certified % card without jQuery selector error - #16
Merged
Merged
Conversation
The card returned its value as text ("0.55%"). Frappe passes the
formatted value to jQuery, which read the plain text as a selector and
threw "unrecognized expression". Return a numeric Percent with
precision 2 instead; show_full_number keeps small values from being
rounded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Work Certified % of Contracts card on the Construction MS workspace did not render. The browser console showed:
The custom card method returned its value as text (
"0.55%", fieldtypeData). Frappe's number card passes the formatted value to jQuery as$(formatted_number). Plain text is read as a CSS selector, and0.55%is not a valid selector. Number fieldtypes come back wrapped in HTML, so they are not affected.Fix
billed_percentnow returns a number, withfieldtype: Percentandprecision: 2. The card already hasshow_full_numberset, so small values such as 0.55% are not shortened to 1%.Testing
On a local v15 site,
billed_percent()returns{'value': 0.5498, 'fieldtype': 'Percent', 'precision': 2, ...}. Frappe's Percent formatter uses the given precision and wraps the result in HTML, so the card shows 0.55% without the console error.🤖 Generated with Claude Code