Repository navigation
docs(spark): fluid apply stops a removed build's runs before it destroys what they run with (forge-cli #1008) - #265
Merged
Merged
Conversation
…oys what they run with (forge-cli #1008)
4 of 8 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents forge-cli #1008, on
main(3492ca20) after the 0.33.0 cut and in no release: when a plan deletes the resources of a Spark build on AWS (the build left the contract, or the product went),fluid applystops the build's runs beforetofu applydestroys the role, the artifacts and the log group they run with.advanced/spark-iceberg-aws.md: a new section, "When a build leaves the contract": the refusal of a policy that is still attached (with the detach commands), the stop of each build's runs, of a Glue job's runs and of the product's own EMR Serverless application, the refusal when a run is still going afterFLUID_SPARK_WAIT_SECONDS, what--dry-rundoes, the three tags that say where a build runs (and the note for a build an earlier forge deployed), and the extra actions the identity that runsfluid applyneeds. Two rows in the Errors table (spark-policy-attached,spark-destroy-runs-going).advanced/environment-variables.md: theFLUID_SPARK_WAIT_SECONDSrow also covers the destroy.upgrading.md: a new section, "Not in a release yet", with one bullet. The earlier section of that name is "Changes in 0.33.0" since docs: every forge-cli change in 0.33.0 reads since 0.33.0, and the releases map is refreshed #263.Related CLI PRs
Areas Updated
Decisions
*On forge-climain, not yet in a release ([forge-cli #1008](...)).*: the pull request merged after the 0.33.0 cut. The pin stays at 0.32.0.fluid applycalls with the plan's deletes beforetofu apply, prints, with AWS answered by botocore's test stubs (which check each call against the real API model) and the plan's deletes built as forge-cli's own tests build them. The section says so. The wiring of the plan's deletes into that step was read from the code. Nothing was destroyed on AWS.Checklist
python scripts/check_cli_docs.py,check_providers.pyandgen_contract_reference.py --checkpass, with forge-cli's liveCHANGELOG.mdNotes
main(docs(spark): a Spark build runs on this machine with spark-submit (forge-cli #975) #264) is merged in.