Repository navigation
feat(checkpoint): separate debt reads from practice writes (#328 D4) - #348
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53544db729
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| practiceCheckpoint: envelopeMethod("practiceCheckpoint", "long", (root: string, input: RuntimePracticeCheckpointInput) => [root, input] as const, (params) => rpcArgs( | ||
| rpcRequiredString(params, 0, "practiceCheckpoint", "root"), | ||
| rpcRequiredObject<RuntimePracticeCheckpointInput>(params, 1, "practiceCheckpoint", "input") |
There was a problem hiding this comment.
Renaming the wire method from checkpoint to practiceCheckpoint while leaving LOCAL_RUNTIME_RPC_SCHEMA_VERSION at archcontext.runtime-rpc/v1 makes incompatible peers appear compatible. A v1 client connected to this daemon passes the version checks and then receives an unknown-method response for checkpoint; conversely, this client fails against an older v1 daemon when it sends practiceCheckpoint, so the normal compatibility path cannot direct users to upgrade the daemon. Preserve a compatibility alias or increment the RPC schema version with this method replacement.
Useful? React with 👍 / 👎.
1 participant
An edit-time checkpoint currently opens the daemon and changes the SQLite practice baseline. This slice makes CLI
checkpoint --changed-pathand MCParchcontext_checkpoint {root,changedPaths?}return the existing architecture-debt/v1 report directly in process, without runtime/session/baseline access. Former checkpoint fields and flags are rejected.Practice updates are explicit:
practices checkpoint,archcontext_practice_checkpoint, and RPCpracticeCheckpoint. The old checkpoint RPC/type is removed; current E2E, FG6, AL10, S6, help, hook metadata, schemas/fixtures and workflow docs move to the corresponding reader or writer. Prepare still seeds a convergent baseline snapshot and declares its state-write effect. Hook reads return debt plus a redacted log; unavailable authority carries the original typed error and unknown coverage, while invalid inputs fail closed.Refs #328 (D4 only). Base: adecdd9. Sole writer: w8:p4 Codex. Dot approved the contract before implementation in Slack thread 1791870900.589399. S4/#347, #346/U4, live model/state, generated projections, historical evidence and the shared feature trio are outside this diff. No merge or release is requested.
Validation on the submitted source:
Details:
docs/researches/20261014-issue-328-stateless-checkpoint.md. Strict 3-second cold-start performance remains unresolved. D5 currently permits cost inventory, D6 error-exit inventory and D7 floor design only; #328 stays open. Hosted CI and Dot's exact-HEAD acceptance are pending.