Skip to content

fix(ci): pin changesets/action to v1 until the CLI moves to v3 - #316

Merged
jordan-simonovski merged 2 commits into
mainfrom
jordansimonovski/pin-changesets-action-v1
Nov 16, 2026
Merged

jordan-simonovski merged 2 commits into
mainfrom
jordansimonovski/pin-changesets-action-v1

Conversation

@jordan-simonovski

@jordan-simonovski jordan-simonovski commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Releases have failed since #309 merged. Dependabot moved changesets/action to v2.1.2, which refuses to run with @changesets/cli v2 (failed run), so the release PR for the six queued changesets never opens. This pins the action back to v1.9.0.

No change for chart users; CI only.

changesets/action v2 refuses to run with @changesets/cli v2, which broke the
release job after #309.
@jordan-simonovski
jordan-simonovski requested a review from a team as a code owner November 16, 2026 22:02
@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b88e349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Helm template coverage

Metric Value
Line coverage 99.85%
Branch coverage 91.00%
Line threshold 99% (met)
Branch threshold 90% (met)
Uncovered details

charts/clickstack/templates/NOTES.txt

Uncovered lines: none

Uncovered branches: 37:default:fallback

charts/clickstack/templates/_helpers.tpl

Uncovered lines: 17

Uncovered branches: 130:range:empty, 132:range:empty, 133:ternary:false, 16:if:true, 194:or(1):true, 211:range:empty, 242:default:fallback, 243:or(1):true, 259:if:false, 327:range:empty, 348:range:empty

charts/clickstack/templates/additional-manifests.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/clickhouse/cluster.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/clickhouse/keeper.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/configmap.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/cronjob-check-alerts.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/dashboard-configmap.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yaml

Uncovered lines: none

Uncovered branches: 40:range:empty

charts/clickstack/templates/hyperdx/deployment.yaml

Uncovered lines: none

Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 26:default:fallback, 41:if:false, 42:with:empty

charts/clickstack/templates/hyperdx/hpa.yaml

Uncovered lines: none

Uncovered branches: 16:with:empty

charts/clickstack/templates/hyperdx/ingress.yaml

Uncovered lines: none

Uncovered branches: 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true

charts/clickstack/templates/hyperdx/networkpolicy.yaml

Uncovered lines: none

Uncovered branches: 11:with:empty

charts/clickstack/templates/hyperdx/pdb.yaml

Uncovered lines: none

Uncovered branches: 10:with:empty

charts/clickstack/templates/hyperdx/secret.yaml

Uncovered lines: none

Uncovered branches: 1:or(2):true, 1:or(3):true

charts/clickstack/templates/hyperdx/service.yaml

Uncovered lines: none

Uncovered branches: 14:default:fallback, 9:with:empty

charts/clickstack/templates/hyperdx/serviceaccount.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/mongodb/community.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/mongodb/password-secret.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/otel-collector/custom-config.yaml

Uncovered lines: none

Uncovered branches: none

@jordan-simonovski
jordan-simonovski enabled auto-merge (squash) November 16, 2026 22:06
@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

Scope: 2 files, ~6 lines (CI only) — .github/workflows/release.yml pins changesets/action v2.1.2 → v1.9.0 (SHA-pinned); .github/dependabot.yml adds a semver-major ignore for that action.
Intent (advisory): Unbreak releases after an auto-bump to the v2 action, which requires @changesets/cli v3 while the repo is on @changesets/cli ^2.29.4.

✅ No critical issues found.

The downgrade is behavior-safe: changesets/action v1 accepts the same commit/title/version/publish inputs and emits the hasChangesets output, so the three downstream steps gated on steps.changesets.outputs.hasChangesets == 'false' are unaffected. The Dependabot ignore is valid YAML, uses the correct dependency-name/update-types keys, and is evaluated before grouping/cooldown — so it suppresses only semver-major bumps of changesets/action while minor/patch of that action and all other actions still flow. The SHA-pin-with-version-comment matches the repo's established action-pinning convention.

One item could not be verified in this environment and is not a finding: the pinned SHA a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d could not be confirmed offline to resolve to tag v1.9.0 (network/gh unavailable). The input/output compatibility conclusion holds for any genuine v1 release regardless of exact minor, so there is no citable failure path — worth a one-line confirmation before merge, no more.


Reviewers (4): correctness, security, project-standards, previous-comments.

Testing gaps:

  • No CI assertion that the pinned v1.9.0 action still emits hasChangesets; the gated release-notes / chart-releaser / GHCR-push steps are only exercised on a real main release run.
  • Dependabot ignore behavior (major changesets/action suppressed, minor/patch still proposed) is not exercised until the next weekly run.
  • Suggested pre-merge check: git ls-remote --tags https://github.com/changesets/action to confirm a45c4d59… matches the v1.9.0 tag commit.

@jordan-simonovski
jordan-simonovski merged commit 71c06c0 into main Nov 16, 2026
12 checks passed
@jordan-simonovski
jordan-simonovski deleted the jordansimonovski/pin-changesets-action-v1 branch November 16, 2026 22:11
jordan-simonovski added a commit that referenced this pull request Nov 17, 2026
Merging main applied #316's v1.9.0 pin and Dependabot ignore on top of this
branch. v1.9.0 ignores the v2 input names and emits hasChangesets, so the
has-changesets checks would skip chart-releaser and the GHCR push.
jordan-simonovski added a commit that referenced this pull request Nov 18, 2026
Moves release tooling to Changesets CLI v3 and `changesets/action` v2,
the versions Dependabot proposed in #309, without changing what a
release produces. Stacked on #316; review once that merges.

- v3 stops versioning private packages by default. The root
`package.json` is private and its version becomes the chart version, so
`.changeset/config.json` sets `privatePackages.version: true`. Without
it, `changeset version` consumes the changesets and leaves the version
at 3.5.0.
- Action v2 renames its inputs and the `hasChangesets` output to
`has-changesets`. The old name reads as empty, which would skip
chart-releaser and the GHCR push on every run while the job still
passed.
- Release and helm-test workflows move to Node 22, which v3 requires
(`^22.11`).
- The `tmp` resolution goes: v3 replaced `external-editor`, the only
package that pulled `tmp` in.
- The Dependabot ignore from #316 is removed.

No change for chart users. Running `yarn changeset` locally needs Node
22.11 or later.

<details>
<summary>Testing</summary>

In a scratch worktree on Node 22.23.1 with the six pending changesets:

- `changeset version` bumps 3.5.0 to 3.6.0 in `package.json` and
`Chart.yaml`, and writes the `## 3.6.0` changelog section that
`extract-release-notes.js` reads.
- `changeset publish` exits 0, publishes nothing and creates no tags.
chart-releaser still does the release.
- `yarn npm audit --all --recursive` reports nothing.

Not exercised locally: the action's API-based push and release PR
creation. The first real run opens the release PR after this merges; the
publish path runs when that release PR merges.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants