Repository navigation
fix(ci): pin changesets/action to v1 until the CLI moves to v3 - #316
Conversation
changesets/action v2 refuses to run with @changesets/cli v2, which broke the release job after #309.
|
Helm template coverage
Uncovered detailscharts/clickstack/templates/NOTES.txtUncovered lines: none Uncovered branches: 37:default:fallback charts/clickstack/templates/_helpers.tplUncovered lines: 17 Uncovered branches: 130:range:empty, 132:range:empty, 133:ternary:false, 16:if:true, 194:or(1):true, 211:range:empty, 242:default:fallback, 243:or(1):true, 259:if:false, 327:range:empty, 348:range:empty charts/clickstack/templates/additional-manifests.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/cluster.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/keeper.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/cronjob-check-alerts.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yamlUncovered lines: none Uncovered branches: 40:range:empty charts/clickstack/templates/hyperdx/deployment.yamlUncovered lines: none Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 26:default:fallback, 41:if:false, 42:with:empty charts/clickstack/templates/hyperdx/hpa.yamlUncovered lines: none Uncovered branches: 16:with:empty charts/clickstack/templates/hyperdx/ingress.yamlUncovered lines: none Uncovered branches: 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true charts/clickstack/templates/hyperdx/networkpolicy.yamlUncovered lines: none Uncovered branches: 11:with:empty charts/clickstack/templates/hyperdx/pdb.yamlUncovered lines: none Uncovered branches: 10:with:empty charts/clickstack/templates/hyperdx/secret.yamlUncovered lines: none Uncovered branches: 1:or(2):true, 1:or(3):true charts/clickstack/templates/hyperdx/service.yamlUncovered lines: none Uncovered branches: 14:default:fallback, 9:with:empty charts/clickstack/templates/hyperdx/serviceaccount.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/community.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/password-secret.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/otel-collector/custom-config.yamlUncovered lines: none Uncovered branches: none |
Deep ReviewScope: 2 files, ~6 lines (CI only) — ✅ No critical issues found. The downgrade is behavior-safe: One item could not be verified in this environment and is not a finding: the pinned SHA Reviewers (4): correctness, security, project-standards, previous-comments. Testing gaps:
|
Merging main applied #316's v1.9.0 pin and Dependabot ignore on top of this branch. v1.9.0 ignores the v2 input names and emits hasChangesets, so the has-changesets checks would skip chart-releaser and the GHCR push.
Moves release tooling to Changesets CLI v3 and `changesets/action` v2, the versions Dependabot proposed in #309, without changing what a release produces. Stacked on #316; review once that merges. - v3 stops versioning private packages by default. The root `package.json` is private and its version becomes the chart version, so `.changeset/config.json` sets `privatePackages.version: true`. Without it, `changeset version` consumes the changesets and leaves the version at 3.5.0. - Action v2 renames its inputs and the `hasChangesets` output to `has-changesets`. The old name reads as empty, which would skip chart-releaser and the GHCR push on every run while the job still passed. - Release and helm-test workflows move to Node 22, which v3 requires (`^22.11`). - The `tmp` resolution goes: v3 replaced `external-editor`, the only package that pulled `tmp` in. - The Dependabot ignore from #316 is removed. No change for chart users. Running `yarn changeset` locally needs Node 22.11 or later. <details> <summary>Testing</summary> In a scratch worktree on Node 22.23.1 with the six pending changesets: - `changeset version` bumps 3.5.0 to 3.6.0 in `package.json` and `Chart.yaml`, and writes the `## 3.6.0` changelog section that `extract-release-notes.js` reads. - `changeset publish` exits 0, publishes nothing and creates no tags. chart-releaser still does the release. - `yarn npm audit --all --recursive` reports nothing. Not exercised locally: the action's API-based push and release PR creation. The first real run opens the release PR after this merges; the publish path runs when that release PR merges. </details>
Releases have failed since #309 merged. Dependabot moved
changesets/actionto v2.1.2, which refuses to run with@changesets/cliv2 (failed run), so the release PR for the six queued changesets never opens. This pins the action back to v1.9.0.changesets/action, so the next weekly group PR can't break the release the same way. chore(ci): move to Changesets CLI v3 and changesets/action v2 #317 moves to CLI v3 and removes the ignore.No change for chart users; CI only.