Repository navigation
chore(ci): move to Changesets CLI v3 and changesets/action v2 - #317
Conversation
changesets/action v2 refuses to run with @changesets/cli v2, which broke the release job after #309.
v3 skips private packages unless privatePackages.version is set, and the root package's version is what becomes the chart version. Action v2 renames its inputs and the has-changesets output that gates chart-releaser. v3 needs Node 22.11+, and no longer pulls in tmp, so its resolution goes.
|
Deep Review✅ No critical issues found. This is a self-contained CI/release-tooling change (Changesets CLI v2→v3, 🟡 P2 -- recommended
🔵 P3 nitpicks (4)
Reviewers (7): correctness, testing, reliability, maintainability, security, project-standards, previous-comments. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. |
Releases have failed since #309 merged. Dependabot moved `changesets/action` to v2.1.2, which refuses to run with `@changesets/cli` v2 ([failed run](https://github.com/ClickHouse/ClickStack-helm-charts/actions/runs/43963152809)), so the release PR for the six queued changesets never opens. This pins the action back to v1.9.0. - Dependabot now skips major bumps of `changesets/action`, so the next weekly group PR can't break the release the same way. #317 moves to CLI v3 and removes the ignore. No change for chart users; CI only.
- helm-test runs the release's version script against a scratch changeset and fails if package.json or Chart.yaml did not bump. - release and helm-test read the Node version from .nvmrc. - package.json declares the Node range @changesets/cli v3 supports.
Not addressing: the pinned v2.1.2
Fixed in 759f623.
Fixed in 759f623, using v3's own range (
Fixed differently in 759f623: release and helm-test read |
Helm template coverage
Uncovered detailscharts/clickstack/templates/NOTES.txtUncovered lines: none Uncovered branches: 37:default:fallback charts/clickstack/templates/_helpers.tplUncovered lines: 17 Uncovered branches: 130:range:empty, 132:range:empty, 133:ternary:false, 16:if:true, 194:or(1):true, 211:range:empty, 242:default:fallback, 243:or(1):true, 259:if:false, 327:range:empty, 348:range:empty charts/clickstack/templates/additional-manifests.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/cluster.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/keeper.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/cronjob-check-alerts.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yamlUncovered lines: none Uncovered branches: 40:range:empty charts/clickstack/templates/hyperdx/deployment.yamlUncovered lines: none Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 26:default:fallback, 41:if:false, 42:with:empty charts/clickstack/templates/hyperdx/hpa.yamlUncovered lines: none Uncovered branches: 16:with:empty charts/clickstack/templates/hyperdx/ingress.yamlUncovered lines: none Uncovered branches: 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true charts/clickstack/templates/hyperdx/networkpolicy.yamlUncovered lines: none Uncovered branches: 11:with:empty charts/clickstack/templates/hyperdx/pdb.yamlUncovered lines: none Uncovered branches: 10:with:empty charts/clickstack/templates/hyperdx/secret.yamlUncovered lines: none Uncovered branches: 1:or(2):true, 1:or(3):true charts/clickstack/templates/hyperdx/service.yamlUncovered lines: none Uncovered branches: 14:default:fallback, 9:with:empty charts/clickstack/templates/hyperdx/serviceaccount.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/community.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/password-secret.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/otel-collector/custom-config.yamlUncovered lines: none Uncovered branches: none |
Merging main applied #316's v1.9.0 pin and Dependabot ignore on top of this branch. v1.9.0 ignores the v2 input names and emits hasChangesets, so the has-changesets checks would skip chart-releaser and the GHCR push.
Moves release tooling to Changesets CLI v3 and
changesets/actionv2, the versions Dependabot proposed in #309, without changing what a release produces. Stacked on #316; review once that merges.package.jsonis private and its version becomes the chart version, so.changeset/config.jsonsetsprivatePackages.version: true. Without it,changeset versionconsumes the changesets and leaves the version at 3.5.0.hasChangesetsoutput tohas-changesets. The old name reads as empty, which would skip chart-releaser and the GHCR push on every run while the job still passed.^22.11).tmpresolution goes: v3 replacedexternal-editor, the only package that pulledtmpin.No change for chart users. Running
yarn changesetlocally needs Node 22.11 or later.Testing
In a scratch worktree on Node 22.23.1 with the six pending changesets:
changeset versionbumps 3.5.0 to 3.6.0 inpackage.jsonandChart.yaml, and writes the## 3.6.0changelog section thatextract-release-notes.jsreads.changeset publishexits 0, publishes nothing and creates no tags. chart-releaser still does the release.yarn npm audit --all --recursivereports nothing.Not exercised locally: the action's API-based push and release PR creation. The first real run opens the release PR after this merges; the publish path runs when that release PR merges.