Skip to content

Coding-agent hooks use the configured complete MCP endpoint - #770

Open
zlareb1 wants to merge 14 commits into
mainfrom
fix/plugin-directory-endpoint
Open

zlareb1 wants to merge 14 commits into
mainfrom
fix/plugin-directory-endpoint

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry

The Claude Code plugin's server_url option takes a complete MCP URL. The separate toolset option is removed; choose the toolset in the URL query. Origin-only configurations must be reconfigured before hooks can contact Loom.

Why

The plugin directory accepts a single configuration reference for an MCP URL. The plugin uses that reference for the complete endpoint and carries checkout context separately, preserving the configured endpoint, credentials and repository scope for concurrent sessions.

Hooks derive their control-plane URL from the same endpoint, including a reverse-proxy prefix. Common configuration validation rejects malformed endpoints before hook network work. Claude Code can still make its own MCP or OAuth discovery requests; a header-helper error does not stop those client requests.

Scope and risk

Plugin configuration, checkout-context handoff, installer/dashboard commands, doctor remediation, English setup docs, mirrored helpers and their tests. Both coding-agent plugin versions change together. Codex retains its fixed MCP configuration contract.

The temporary Claude checkout-context file contains the working directory, session ID and native client process identity, without tokens or transcripts. It survives session end and is eligible for best-effort pruning by a later SessionStart after a day without a write. The standalone and published Claude Code disclosures name this file and the bounded macOS process and Windows WMI commands. Codex skips the artifact and these process queries. Native process identity differs by platform, so platform CI must pass before merge.

Compatibility, rollout and rollback

  • Wire: no server operation or schema change.
  • Plugin configuration break: server_url now means the complete MCP URL, and the standalone toolset option is retired. Existing origin-only configurations receive an actionable reconfiguration notice. Set the full /mcp?toolset=coding URL, or a supported toolset union in that query, using the documented plugin configuration command.
  • Old dashboards can still emit an origin-only install command during a rolling upgrade. The notice remains necessary until those installations are reconfigured; there is no silent destination fallback.
  • Operator steps: reconfigure affected Claude Code installations; the updated installer/dashboard emit the full URL.
  • Rollback: revert the plugin change and reconfigure affected installations to the restored option contract.

Tests

All 22 directly related identity and header-helper checks pass. They exercise the shipped static Windows helper with COM fixtures, exact UTC creation strings, percent-encoded Unicode names, missing or multiple results, malformed records, unsafe PIDs and existing checkout-cache isolation. Changed JavaScript passes syntax and formatting checks, and mirrored plugin files pass the generator check.

Windows fixture bootstraps use file URLs. The host is resolved from the parent OS environment's absolute, drive-qualified SystemRoot, without executable lookup in the checkout. Missing or malformed roots fail closed. Process identity uses the installed Windows Script Host and the plugin's static JScript helper for one projected local WMI query, with the same one-second timeout and no command-line or environment collection. A missing or blocked component fails closed; no component is installed or enabled. Native Windows x64 and arm64 CI must verify availability, timing and concurrent-checkout credentials and scope; local COM fixtures cannot establish those properties.

Full Python unit/benchmark, plugin validation and Node/shell checks, native clients across the platform matrix, and dashboard test/build/budget/browser checks must pass in PR CI before merge. The model-based plugin eval remains pending. No real model provider was called.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated (an agent wrote most of the diff): Codex implemented the plugin changes and checked the contracts against local client fixtures.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • make format-check, make lint, make typecheck and make test-unit pass; the integration suite passes if server behaviour changed.
  • Plugin validation, sync, Node/shell checks and the required platform matrix pass.
  • Full dashboard tests, build, budget and browser gates pass.
  • The disclosure includes the checkout-context artifact and the existing standalone disclosure changes.
  • No generated translation was edited by hand.
  • Commits are signed off.

Derive hook URLs and toolset guidance from the endpoint used by directory
installs. Pass checkout context through private state keyed to the client
process instead of a URL fragment.

Retire the standalone toolset option. Origin-only server_url installations
must configure /mcp and the desired query. Invalid configuration prints an
actionable notice without sending Loom credentials.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The endpoint query must stay one literal argument in shells that reject unmatched globs.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Standalone plugin pages need the local process commands and retention rules for the Claude checkout artifact. Keep the installed endpoint contract test aligned with the complete URL option.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Separate the Claude endpoint selection from the generic environment and file URL lookup in the shared helper comment.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signup uses the same resolved base as the endpoint transport so repeated path separators reach the configured proxy route and remain in saved configuration.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Generic and fixed clients accept control-plane origins. Restrict complete-endpoint parsing and install state to the configurable endpoint client so startup retains its primer and collection reads.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Save a credential-free invalid marker before startup refuses a malformed endpoint so the standalone diagnostic cannot report success against an older server.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Match the manifest expansion when the environment base ends in a slash. Reject distinct supplied bases and retain their separators in credential-source warnings.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant