Repository navigation
Normalize inherited style output - #26
Merged
Merged
Conversation
Contributor
pirate-bot
approved these changes
Nov 13, 2026
Contributor
There was a problem hiding this comment.
🟢 Approved
Approved: inherited Neve values now enter the inline style without markup, and valid values render as before.
Validation details
- Files reviewed: 2/2 changed files.
- The frontend, editor and welcome-notice styles all reach the inline style through
Assets_Manager::enqueue_style(). - Valid colors, font families, weights, sizes and the radius contain no
<, so stripping leaves them unchanged. - The new test passes at HEAD on PHP 7.4 with PHPUnit 6.5.14 [R12].
- On the base tree, the new test fails:
cd /var/www/html/wp-content/themes/eduacademy-base && set -o pipefail; timeout 280 vendor/bin/phpunit --filter 'Test_Ass…printedFailed asserting that ':root{--neve-font-weight-body:<em>700</em>;}' contains "--neve-font-weight-body:700;".(run R13)
Untested areas
- The installed Neve version and
theme_mod_*filter outputs were not checked. - The checkout path breaks the test bootstrap's theme slug. The tests ran from theme-directory copies.
🤖 Automated review · run code-review-agent_6af70469c5a629.48975411.
🤖 Review agent — review posted ✅ on c05a7ed0 · approved · 0 findings · 9 min
Run code-review-agent_6af70469c5a629.48975411 · trail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eduacademy copies typography, color and button values from Neve into an inline style block. Those values now enter that block as CSS text only, with any markup removed.
What changed
Inherited Neve styles —
Assets_Manager::enqueue_style()strips tags from the inherited CSS variables before adding them inline. This covers both the frontend and the editor stylesheet, which share this path.Unchanged output — valid colors, font families, weights, sizes and the button radius render as before.
Coverage —
tests/test-assets-manager.phpchecks that a font weight with markup becomes plain CSS.QA
Activate Neve, set a typography font weight and a global color in
Appearance → Customize, then switch to Eduacademy.Expect: the frontend uses the same weight and color as before, and the page source shows them as
--neve-…variables in the inline style.