Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/Assets_Manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static function enqueue_style( string $handle, string $file, array $depen
// Add the inherited values from Neve.
$inherited_style_values = self::get_inherited_style_values();
if ( ! empty( $inherited_style_values ) ) {
wp_add_inline_style( $handle, $inherited_style_values );
wp_add_inline_style( $handle, wp_strip_all_tags( $inherited_style_values ) );
}
}

Expand Down
54 changes: 54 additions & 0 deletions tests/test-assets-manager.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<?php
/**
* Tests for inherited theme styles.
*
* @package eduacademy
*/

use Eduacademy\Assets_Manager;
use Eduacademy\Neve_Mods;

/**
* Test inherited style output.
*/
class Test_Assets_Manager extends WP_UnitTestCase {
/**
* Restore the inherited-mod cache after each test.
*
* @return void
*/
public function tearDown() {
Neve_Mods::$instance = null;
delete_option( 'theme_mods_neve' );
wp_dequeue_style( 'eduacademy-test-style' );
wp_deregister_style( 'eduacademy-test-style' );

parent::tearDown();
}

/**
* Inherited values should not add markup to an inline style block.
*
* @return void
*/
public function test_inherited_style_values_strip_markup() {
update_option(
'theme_mods_neve',
array(
'neve_typeface_general' => array(
'fontWeight' => '<em>700</em>',
),
)
);

Neve_Mods::$instance = null;
Assets_Manager::enqueue_style( 'eduacademy-test-style', 'style' );

$inline_styles = wp_styles()->get_data( 'eduacademy-test-style', 'after' );
$inline_style = implode( "\n", $inline_styles );

$this->assertStringContainsString( '--neve-font-weight-body:700;', $inline_style );
$this->assertStringNotContainsString( '<em>', $inline_style );
$this->assertStringNotContainsString( '</em>', $inline_style );
}
}
Loading