Fix module settings param for Lucee 6 - COLDBOX-1385#650
Open
michaelborn wants to merge 1 commit intoColdBox:developmentfrom
Open
Fix module settings param for Lucee 6 - COLDBOX-1385#650michaelborn wants to merge 1 commit intoColdBox:developmentfrom
michaelborn wants to merge 1 commit intoColdBox:developmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Lucee 6 parsing incompatibility in ModuleService when ensuring a nested moduleSettings struct exists for a module namespace.
Changes:
- Replaces
param name="globalModuleSettings[ ... ]"usage with an explicitkeyExists()check and initialization. - Preserves the existing behavior of merging global module settings into module config settings.
| .getSetting( "ColdBoxConfig" ) | ||
| .getPropertyMixin( "moduleSettings", "variables", {} ); | ||
| param name="globalModuleSettings[ mConfig.modelNamespace ]" default="#structNew()#"; | ||
| if( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) { |
There was a problem hiding this comment.
Spacing around the if condition is inconsistent with the rest of this file (which uses if ( ... )). Please format this as if ( ... ) for consistency/readability.
Suggested change
| if( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) { | |
| if ( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lucee 6.2.5+48 does not like this syntax in coldbox's ModuleService:
Jira Issues
https://ortussolutions.atlassian.net/browse/COLDBOX-1385
Type of change
Please delete options that are not relevant.
Checklist