Skip to content

Fix module settings param for Lucee 6 - COLDBOX-1385 #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelborn wants to merge 1 commit into
base: development
Choose a base branch
from
+3 −1
Open

Fix module settings param for Lucee 6 - COLDBOX-1385 #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion system/web/services/ModuleService.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,7 +1316,9 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
var globalModuleSettings = controller
.getSetting( "ColdBoxConfig" )
.getPropertyMixin( "moduleSettings", "variables", {} );
param name="globalModuleSettings[ mConfig.modelNamespace ]" default="#structNew()#";
if( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) {
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing around the if condition is inconsistent with the rest of this file (which uses if ( ... )). Please format this as if ( ... ) for consistency/readability.

Suggested change
if( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) {
if ( !globalModuleSettings.keyExists( mConfig.modelNamespace ) ) {

Copilot uses AI. Check for mistakes.
globalModuleSettings[ mConfig.modelNamespace ] = structNew();
}
mConfig.settings.append( globalModuleSettings[ mConfig.modelNamespace ], true );

// config/{mConfig.modelNamespace}.cfc overrides
Expand Down
Loading