Repository navigation
fix(anvil): finish click results on the next tick - #107
Merged
Merged
Conversation
Closing the anvil inside the click left the client a predicted cursor item that creative players could keep.
Owner
|
The next-tick change looks right. Paper skips its normal sync when the menu changes during the click event, so deferring the close addresses the cause. One small request: |
The screen has already switched back to the player's inventory menu by the time this guard runs, so the call never executes.
Owner
|
Went ahead and pushed the small cleanup myself so this does not have to sit around. I just removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the result (or cancel) slot of the anvil prompt closed the inventory inside the click event. The client kept its predicted cursor item, a copy of the input item, and in creative mode that item became real. Players got name tags (or the configured input item) in their inventory after answering a prompt.
updateInventory()after closing, so the client drops any stale cursor/slot state.Tested on a live Paper server: answering an anvil prompt in creative no longer leaves items behind.