Skip to content

fix(anvil): finish click results on the next tick #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyR1en merged 2 commits into from
Nov 9, 2026
Merged

fix(anvil): finish click results on the next tick #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beafc32
fix(anvil): finish click results on the next tick
bobhenl Nov 8, 2026
1bceb35
fix(anvil): remove unreachable inventory update
CyR1en Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions prompt-ui-26.1/src/main/java/dev/cyr1en/promptui/v26_1/FrameworkAnvilScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ private void openOnPlayerThread() {
plugin
.getSLF4JLogger()
.debug("FrameworkAnvilScreen result: player={}", player.getName());
complete(ScreenResult.answer(answer), true);
event.setCancelled(true);
completeAfterClick(ScreenResult.answer(answer));
});

anvilGui.createInventory();
Expand Down Expand Up @@ -241,7 +242,8 @@ private void setupItems() {
plugin
.getSLF4JLogger()
.debug("FrameworkAnvilScreen cancel: player={}", player.getName());
complete(ScreenResult.manualCancel(), true);
event.setCancelled(true);
completeAfterClick(ScreenResult.manualCancel());
});
anvilGui.getSecondItemComponent().addItem(cancelGuiItem, 0, 0);
}
Expand Down Expand Up @@ -295,6 +297,24 @@ public void close() {
scheduleCleanup(gui, impl, true);
}

/**
* Finishes a click-triggered result on the next tick. Closing the anvil inside the click event
* left the client holding its predicted cursor item (a copy of the input), which creative-mode
* players could then keep. Waiting one tick lets the server resync the cancelled click first.
*/
private void completeAfterClick(ScreenResult result) {
try {
ScheduledTask task =
player.getScheduler().run(plugin, ignored -> complete(result, true), null);
if (task != null) {
return;
}
} catch (Throwable ignored) {
// Fall through and finish now.
}
complete(result, true);
}

private void complete(ScreenResult result, boolean closePlayer) {
AnvilGui gui;
AnvilInventoryImpl impl;
Expand Down
24 changes: 22 additions & 2 deletions prompt-ui-26.2/src/main/java/dev/cyr1en/promptui/v26_2/FrameworkAnvilScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ private void openOnPlayerThread() {
plugin
.getSLF4JLogger()
.debug("FrameworkAnvilScreen result: player={}", player.getName());
complete(ScreenResult.answer(answer), true);
event.setCancelled(true);
completeAfterClick(ScreenResult.answer(answer));
});

anvilGui.createInventory();
Expand Down Expand Up @@ -238,7 +239,8 @@ private void setupItems() {
plugin
.getSLF4JLogger()
.debug("FrameworkAnvilScreen cancel: player={}", player.getName());
complete(ScreenResult.manualCancel(), true);
event.setCancelled(true);
completeAfterClick(ScreenResult.manualCancel());
});
anvilGui.getSecondItemComponent().addItem(cancelGuiItem, 0, 0);
}
Expand Down Expand Up @@ -292,6 +294,24 @@ public void close() {
scheduleCleanup(gui, impl, true);
}

/**
* Finishes a click-triggered result on the next tick. Closing the anvil inside the click event
* left the client holding its predicted cursor item (a copy of the input), which creative-mode
* players could then keep. Waiting one tick lets the server resync the cancelled click first.
*/
private void completeAfterClick(ScreenResult result) {
try {
ScheduledTask task =
player.getScheduler().run(plugin, ignored -> complete(result, true), null);
if (task != null) {
return;
}
} catch (Throwable ignored) {
// Fall through and finish now.
}
complete(result, true);
}

private void complete(ScreenResult result, boolean closePlayer) {
AnvilGui gui;
AnvilInventoryImpl impl;
Expand Down
24 changes: 22 additions & 2 deletions prompt-ui-26.3/src/main/java/dev/cyr1en/promptui/v26_3/FrameworkAnvilScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ private void openOnPlayerThread() {
plugin
.getSLF4JLogger()
.debug("FrameworkAnvilScreen result: player={}", player.getName());
complete(ScreenResult.answer(answer), true);
event.setCancelled(true);
completeAfterClick(ScreenResult.answer(answer));
});

anvilGui.createInventory();
Expand Down Expand Up @@ -238,7 +239,8 @@ private void setupItems() {
plugin
.getSLF4JLogger()
.debug("FrameworkAnvilScreen cancel: player={}", player.getName());
complete(ScreenResult.manualCancel(), true);
event.setCancelled(true);
completeAfterClick(ScreenResult.manualCancel());
});
anvilGui.getSecondItemComponent().addItem(cancelGuiItem, 0, 0);
}
Expand Down Expand Up @@ -292,6 +294,24 @@ public void close() {
scheduleCleanup(gui, impl, true);
}

/**
* Finishes a click-triggered result on the next tick. Closing the anvil inside the click event
* left the client holding its predicted cursor item (a copy of the input), which creative-mode
* players could then keep. Waiting one tick lets the server resync the cancelled click first.
*/
private void completeAfterClick(ScreenResult result) {
try {
ScheduledTask task =
player.getScheduler().run(plugin, ignored -> complete(result, true), null);
if (task != null) {
return;
}
} catch (Throwable ignored) {
// Fall through and finish now.
}
complete(result, true);
}

private void complete(ScreenResult result, boolean closePlayer) {
AnvilGui gui;
AnvilInventoryImpl impl;
Expand Down
Loading